Bug 128632 - entries in the tools menu don't work as they should
Summary: entries in the tools menu don't work as they should
Status: RESOLVED INTENTIONAL
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-04 19:57 UTC by Joerg de la Haye
Modified: 2008-10-26 12:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg de la Haye 2006-06-04 19:57:26 UTC
Version:            (using KDE KDE 3.5.3)
Installed from:    Debian testing/unstable Packages

The entries in the tools menu don't work as they should. 
If I take a screenshot, krita doesn't do anything with it. The screenshot tool disappears and that's all. It's exactly the same for the scan tool. Btw., the scan tool doesn't appear in the tools menu itself, I've had to add it to /usr/share/apps/krita/krita.rc manually.

In kword the desired functionality works perfectly, after using the scan tool kword switches to an insert mode and you can insert your scanned image wherever you want to.

I'm using a freshly installed version of koffice 1.5.1, the behaviout is the same for the precompiled Debian packages and for a self-compiled one from the koffice-tarball.
Comment 1 Halla Rempt 2006-06-07 13:48:18 UTC
This used to work just fine :-( (Not the scan thing: I cannot test that since I don't have a scanner, but the screenshot plugin.)
Comment 2 Joerg de la Haye 2006-06-07 14:39:36 UTC
"Nice" to know that it is not a me-only bug.

About your lack of a scanner: the second problem is that the scan tool doesn't appear at all, it doesn't matter if it's plugged in or not. In kword you can find it in the insert menu, and then again, it doesn't matter if it's plugged in or not.

Should I fill another bug report for that?
Comment 3 Halla Rempt 2006-06-07 14:41:09 UTC
Yes, that would helpful. Thanks!
Comment 4 Bart Coppens 2006-06-17 13:39:34 UTC
SVN commit 552300 by coppens:

Make screenshot plugin work again. No clue as to why it suddenly stopped working, though.
CCBUG:128632

 M  +1 -1      plugins/viewplugins/screenshot/screenshot.cpp  
 M  +10 -10    ui/kis_view.h  


--- branches/koffice/1.6/koffice/krita/plugins/viewplugins/screenshot/screenshot.cpp #552299:552300
@@ -72,5 +72,5 @@
 
     KisView *view = dynamic_cast<KisView *>(parent());
     if(view)
-        view->koDocument()->import(temp.name());
+        view->importImage(temp.name());
 }
--- branches/koffice/1.6/koffice/krita/ui/kis_view.h #552299:552300
@@ -212,7 +212,15 @@
     void insertPart(const QRect& viewRect, const KoDocumentEntry& entry,
                     KisGroupLayerSP parent, KisLayerSP above);
 
-
+    /**
+     * Import an image as a layer. If there is more than
+     * one layer in the image, import all of them as separate
+     * layers.
+     * 
+     * @param url the url to the image file
+     * @return the number of layers added
+     */
+    Q_INT32 importImage(const KURL& url = KURL());
 protected:
 
     virtual void resizeEvent(QResizeEvent*); // From QWidget
@@ -375,15 +383,7 @@
     void setupScrollBars();
     void setupStatusBar();
 
-    /**
-     * Import an image as a layer. If there is more than
-     * one layer in the image, import all of them as separate
-     * layers.
-     * 
-     * @param url the url to the image file
-     * @return the number of layers added
-     */
-    Q_INT32 importImage(const KURL& url = KURL());
+
     KisFilterManager * filterManager() { return m_filterManager; }
     void setCurrentImage(KisImageSP image);
 
Comment 5 Halla Rempt 2008-10-26 12:09:11 UTC
In 2.0, both scan and screenshot tool have gone. The scanning tool might return, but will need a complete rewrite, the screenshot probably won't come back.