Bug 128614 - [Patch] Keyboard right click button has no effect in playlist
Summary: [Patch] Keyboard right click button has no effect in playlist
Status: RESOLVED UNMAINTAINED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 1.4.5
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-04 13:50 UTC by Marius
Modified: 2009-03-19 20:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch Fixing the eventloop to accept the keystroke (986 bytes, patch)
2007-02-11 15:02 UTC, xbvdf.1000.Toranaga-San
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marius 2006-06-04 13:50:53 UTC
Version:           1.4.0 (using KDE KDE 3.5.2)
Installed from:    Gentoo Packages

Trying to right click on an item in the playlist using the right click keyboard button (the one between the right ctrl and alt) has no effect.

It should work like on every other program in the world, as a right click action.
Comment 1 Marius 2006-11-28 14:59:35 UTC
Still applies to amarok 1.4.4

My guess is that this would probably be something like a oneliner to fix.
Comment 2 Martin Aumueller 2006-12-28 22:45:56 UTC
We changed the context menu handling code for 1.4.5. Could you please check with current svn or 1.4.5 or newer, if this fixed your problem?
Comment 3 Alexandre Oliveira 2006-12-29 01:26:44 UTC
I can confirm it doesn't work
Comment 4 Kevin Funk 2007-02-08 18:31:58 UTC
Doesn't work for me in 1.4.5, either.
Comment 5 xbvdf.1000.Toranaga-San 2007-02-11 15:02:42 UTC
Created attachment 19619 [details]
Patch Fixing the eventloop to accept the keystroke
Comment 6 xbvdf.1000.Toranaga-San 2007-02-11 17:27:38 UTC
Comment on attachment 19619 [details]
Patch Fixing the eventloop to accept the keystroke

>Index: amarok/src/playlistwindow.cpp
>===================================================================
>--- amarok/src/playlistwindow.cpp	(Revision 631281)
>+++ amarok/src/playlistwindow.cpp	(Arbeitskopie)
>@@ -41,6 +41,7 @@
> #include "threadmanager.h"
> #include "magnatunebrowser/magnatunebrowser.h"
> 
>+#include <qcursor.h>
> #include <qevent.h>           //eventFilter()
> #include <qfont.h>
> #include <qheader.h>
>@@ -657,6 +658,14 @@
> 
>             return true;
>         }
>+	if(e->key() == Qt::Key_Menu && o == pl)
>+        {
>+            pl->contentsMousePressEvent( new QMouseEvent( QEvent::MouseButtonPress,
>+                                                          pl->viewport()->mapFromGlobal( QCursor::pos() ),
>+                                                          Qt::RightButton,
>+                                                          Qt::NoButton ));
>+        }
> 
>         if( e->state() & ControlButton )
>         {
Comment 7 Anne-Marie Mahfouf 2007-02-11 20:45:11 UTC
I tested the patch and it works great.
This is an overall usual feature that users would like to see in Amarok as it exists in other KDE apps.
Comment 8 Kevin Funk 2007-03-06 18:40:40 UTC
If someone could send this to SVN...?
Comment 9 Myriam Schweingruber 2008-08-06 06:58:51 UTC
Has this been done yet?
Comment 10 Myriam Schweingruber 2009-03-19 20:42:00 UTC
Amarok 1.x is not maintained anymore.