Bug 128217 - rev. 545330 broke xine engine FLAC playback
Summary: rev. 545330 broke xine engine FLAC playback
Status: RESOLVED NOT A BUG
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-28 23:22 UTC by Benjamin K. Stuhl
Modified: 2006-06-11 12:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
not a real patch (607 bytes, text/plain)
2006-05-28 23:25 UTC, Benjamin K. Stuhl 		Details
xine patch to fix the issue (2.58 KB, patch)
2006-05-29 00:11 UTC, Diego Elio Pettenò 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin K. Stuhl 2006-05-28 23:22:34 UTC 
Version:           SVN (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 4.1.1 
OS:                Linux

The new "do I have an mp3 decoder" check introduced in rev. 545330 also seems to fail on FLAC files... and so amaroK doesn't play them anymore.
Comment 1 Benjamin K. Stuhl 2006-05-28 23:25:15 UTC 
Created attachment 16313 [details]
not a real patch

The attached "patch" (not a fix!) demonstrates the problem: with out the patch,
none of my FLAC files play, but with it they all do.
Comment 2 simon 2006-05-28 23:31:42 UTC 
Yes can confrim that here. 
It seems that this xine funtion does not work for flac files because in xine itselft it also says "has audio: no" while playing the audio fine.
Comment 3 Diego Elio Pettenò 2006-05-29 00:04:07 UTC 
This is a xine bug, testing a patch while I'm talking.

Remains the problem for the distributions that are not "on the loop" with xine, as a new release is unlikely ATM.
Comment 4 Diego Elio Pettenò 2006-05-29 00:11:57 UTC 
Created attachment 16315 [details]
xine patch to fix the issue

This is the patch I've added to Gentoo's xine-lib and I'm sending upstream that
solves the issue.
Comment 5 Mark Kretschmann 2006-05-30 18:29:32 UTC 
Closing. Obviously not an amaroK bug.