Bug 123378 - <ctrl>-s save shortcut is missing
Summary: <ctrl>-s save shortcut is missing
Status: CONFIRMED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml part (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-10 13:26 UTC by ian
Modified: 2021-03-21 00:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ian 2006-03-10 13:26:02 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    Gentoo Packages

I've just updated from KDE 3.2.1 to KDE 3.5.1 and have noticed that the <ctrl>-s keyboard shortcut to save a page when using Konqueror is missing.  This is a very useful and timesaving function for me.  The alternative which is to go through with the mouse into the "Location" menu then choose "Save As" is very cumbersome.  Please fix this problem and restore the save keyboard shortcut as soon as possible!
Comment 1 Thiago Macieira 2006-03-11 18:55:43 UTC
Indeed, this commit broke it:

------------------------------------------------------------------------
r302860 | binner | 2004-04-11 19:37:59 +0200 (Sun, 11 Apr 2004) | 2 lines

More KStdGuiItems: less strings, more icons

------------------------------------------------------------------------

in khtml_part.cpp:
-  d->m_paSaveDocument = new KAction( i18n( "&Save As..." ), CTRL+Key_S, this, SLOT( slotSaveDocument() ), actionCollection(), "saveDocument" );
+  d->m_paSaveDocument = KStdAction::saveAs( this, SLOT( slotSaveDocument() ), actionCollection(), "saveDocument" );
Comment 2 ian 2007-04-04 17:10:45 UTC
Hi,

Just updated to KDE 3.5.6, and this bug seems to not be fixed.

Is there a scheduled release for the fixing of this bug, or is there a patch I can apply to the source to fix it on my builds?
Comment 3 ian 2007-07-13 13:12:35 UTC
Updated to Konqueror 3.5.7.  Bug not fixed :-(
Comment 4 Dawit Alemayehu 2007-07-14 16:30:16 UTC
As already mentioned in comment #1, this indeed seems to have been advertently or inadvertently changed with commit r302860, but you do know that you can map this shortcut yourself right ?  Just in case you do not, here are the steps:

1.) Settings->Configure Shortcuts
2.) In the 'Search' box, type Save.
3.) Select 'Save As...'
4.) In 'Shortcut for Selected Action' box, click on 'Custom'
5.) Click on the button besides 'Custom'.
6.) Press the shortcut key you want. CTRL+S in your case.

If there is a conflict and there will be because CTRL+S is currently assigned to 'Focus Searchbar', simply choose reassign when the conflict resolution dialog box pops up.
Comment 5 ian 2007-08-06 16:15:22 UTC
Yes, I know I can reassign, however I believe we have a design problem here now too.  CTRL-S is the save shortcut in pretty much every application I know.  Konqueror seems to be the only execption to that, something that has been only recently introduced.  

This is a significant inconsistency in application design.  We want applications to have consistent keyboard shortcuts with each other.  Having it as save in most applications, and as something different in a couple of other applications creates confusion for the users.  This is especially true when changing between browsers.  Every other browser I know of uses CTRL+s for save, why should Konqueror alienate itself in this manner?

'Focus Searchbar' should have a different shortcut, I would suggest CTRL+k as it is in firefox.  This achieves consistency between applications, particularly with the dominant open source application, and prevents other people saying that "application x", in this case konqueror, is crap.  Believe me, I get this a lot in my office where we use primarily Open Source and Linux of various flavours.  (My use of KMail is often the brunt of such comments, despite issues being only minor, such as this with Konqueror).  As another possible alternative shortcut for Focus Searchbar, you could use CTRL+capital-S (capital 'S', not lowercase 's'), which may also get accepted and which I think is also a reasonable alternative to the current design.

I do hope this will be changed back to what it was before, to make Konqueror consistent with all other applications.
Comment 6 James Spahlinger 2008-04-19 16:17:36 UTC
Save works with CTRL + S in konqueror 4.0.3

Using Gentoo Linux ~x86 (testing in gentoo lingo). KDE 4.0.3 and the majority of packages compiled using gcc 4.3.0.
Comment 7 FiNeX 2008-04-25 13:45:05 UTC
@James: I've just tried the revision 800924 and the "Save as" action is not binded to CTRL+S. The same happen in 3.5.9.
Comment 8 Stephan Sokolow 2009-02-13 06:56:50 UTC
I can confirm this problem with KDE 4.2.0 on Gentoo.

I'm using USE="kdeprefix", so it generated ~/.kde4.2/ for user data and used a default profile.
Comment 9 ian 2009-02-13 13:53:12 UTC
OK guys, we know which commit broke it.  
As I said in my comment from 2007-08-06 16:15:22, this also breaks consistency from the general user intarface, ctrl-s saves in just about every other kde application that I know of, in fact there's none that I can think of that doesn't have this shortcut for save implemented.  Even Firefox has the ctrl-s shortcut for save and ctrl-k for search.  Why has this consistency with the save shortcut been broken in Konqueror?

More importantly, when will this be finally taken care of?  It is after all only one line of code to be changed.  What organisational barriers stand in the way of making this change and restoring consistent functionality?

Maybe I can suggest a patch???
in khtml_part.cpp:
-  d->m_paSaveDocument = KStdAction::saveAs( this, SLOT( slotSaveDocument() ),
actionCollection(), "saveDocument" );
+  d->m_paSaveDocument = new KAction( i18n( "&Save As..." ), CTRL+Key_S, this,
SLOT( slotSaveDocument() ), actionCollection(), "saveDocument" );
Comment 10 ian 2009-08-13 16:51:58 UTC
KDE 4.3.0 still has this problem.  When will it be fixed?
I've just updated to KDE 4.3.0 from 3.5.9.  4.3 a disaster next to kde 3.5! Usability has been badly killed off!
Comment 11 FiNeX 2009-08-14 20:06:18 UTC
@Ian: Your second sentence is completely unuseful and not constructive.
Comment 12 ian 2009-08-17 13:50:39 UTC
@FiNeX: Comments like that express frustration, and when they get posted in a bug report in this manner, the frustration is very high! Developers should be able to see and understand this.
Comment 13 FiNeX 2009-08-17 14:33:30 UTC
@Ian: I suggest you to report your bad experience, not only to say how bad it was :-)

This is one of the many bugs. Please, give an eye to the already reported bugs/wishes and, if you want, report what you think is missing :-)

bye.
Comment 14 Justin Zobel 2021-03-21 00:25:12 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 10 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.