Version: 3.4.91 (using KDE KDE 3.4.90) Installed from: Gentoo Packages this bug is in KDE 3.5 beta1! 1. open konqueror 2. goto www.toto.tk 3. click on the back button (which shouldn't be there, or? cause we started with a blank site in konqueror) before the 15s left 4. "Malformed URL ." message appears
Confirmed on KDE 3.5 r449049. I believe this is the same error as bug #112875
*** Bug 114735 has been marked as a duplicate of this bug. ***
*** Bug 113408 has been marked as a duplicate of this bug. ***
Bug is still there in KDE 3.5.4. Test case: http://www.amazon.de/gp/product/0553288105/ Click on the image of the book to get bigger view (opening new links in tabs must be enabled). The bigger image page has an illegal back button.
*** Bug 133042 has been marked as a duplicate of this bug. ***
*** Bug 125666 has been marked as a duplicate of this bug. ***
*** Bug 128106 has been marked as a duplicate of this bug. ***
*** Bug 140784 has been marked as a duplicate of this bug. ***
Created attachment 20702 [details] errormsg screenshot present in KDE 3.5.7, example (hopefully) with screenie: preparation: configure Konqueror to "open links in new tab instead of new window" goto: www.kde-apps.org a) choose an entry b) click on the preview-screenie (1) new window opens in tab and offers to go back in history -> click the back butten (2) c) a fancy error message appears twice. (3)
This patch appears to fix the problem (to be applied in kdebase/konqueror): Index: konq_view.cc =================================================================== --- konq_view.cc (revision 655366) +++ konq_view.cc (working copy) @@ -728,7 +728,9 @@ #ifdef DEBUG_HISTORY kdDebug(1202) << "Append a new entry" << endl; #endif - m_lstHistory.append( new HistoryEntry ); // made current + if (m_sLocationBarURL != "") { + m_lstHistory.append( new HistoryEntry ); // made current + } #ifdef DEBUG_HISTORY kdDebug(1202) << "at=" << m_lstHistory.at() << " count=" << m_lstHistory.count() << endl; #endif
Created attachment 20770 [details] proposed patch Attaching the patch for ease of saving
Created attachment 23427 [details] more general patch to avoid creating empty history entries I also wanted to report this.. now I created a patch against trunk and hope it is accepted for inclusion..
Created attachment 23441 [details] real fix: do not first open empty tab, then goto url instead open url straight away Do NOT try this at home kids. My previous patch is extremly wrong and crashes badly. I am so sorry and hereby pledge to never unleash untested patches onto the net. Here's one against libs/ecma/kjs_window.cpp that actually fixes the source of the symptom. Will try and eradicate that malformed url thing later on.
running with this patch since weeks, fixes the problem without side effects, could someone please review and commit this so i can clean my local tree..cheers!
Bug reproduced on 3.5.9 AND 4.1 (trunk r802881).
@Finex: How exactly did you manage to reproduce that with 4.1? I tried it myself, and konqueror didn't show any error. This what I did: 1. Set konqueror to start with a blank page 2. Start a new konq instance 3. got to www.toto.tk 4. the back button is displayed, hitting it goes back to the blank page. this of course also works with any start page other than a blank page. I also tried to directly go to the above url by launching konqueror with the url as parameter from klauncher. In that case the back button is not displayed. So I consider this issue fixed for 4.1
Oh, thanks Dominik to have tested it. It's true, it has been fixed recently (On KDE4, of course). I'm closing it.
What about patch in #23441? Although this problem itself is fixed, this patch would still improve the code, wouldn't it? Why first open a window with an empty URL p->browserExtension()->createNewWindow(KUrl(), args, browserArgs, winargs, &newPart); and only after that khtmlpart->browserExtension()->openUrlRequest(url, args, browserArgs); ? I've been running with this patch attached since half a year without a problem.. ?