Bug 109938 - cannot delete cool-streams playlist
Summary: cannot delete cool-streams playlist
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.2.3
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-31 16:26 UTC by min
Modified: 2007-01-27 10:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Add 'hide cool streams' configuration checkbox (640 bytes, patch)
2005-07-31 22:21 UTC, min
Details
add checkbox (42 bytes, patch)
2005-07-31 22:25 UTC, min
Details
don't show Cool-Streams if they are hidden (350 bytes, text/plain)
2005-07-31 22:34 UTC, min
Details
change to kcfg file (246 bytes, text/plain)
2005-07-31 22:36 UTC, min
Details

Note You need to log in before you can comment on or make changes to this bug.
Description min 2005-07-31 16:26:24 UTC
Version:           1.2.3 (using KDE 3.4.2, Kubuntu Package 4:3.4.2-0ubuntu0hoary1 )
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-8ubuntu2)
OS:                Linux (i686) release 2.6.10-5-686

If I delete the cool-streams playlist (ok, I know they're cool, but it's still a playlist and it should be removable), cool-streams will be restored when I restart amarok.

Moreover, amarok shows me a popup saying "You have selected 1 playlist to be irreversibly deleted.", which is true (I have indeed selected it for that purpose) and false (it won't work, it will not be irreversably deleted - in fact, it will not be deleted at all)
Comment 1 Alexandre Oliveira 2005-07-31 16:33:12 UTC
Sorry, but the same that was explained in bug #98030 applies here.
And in new versions, the delete option is not shown for them anymore.
Thanks for the report anyway. :-)
Comment 2 min 2005-07-31 17:09:27 UTC
Sorry for reopening this, and I know it's an annoying gesture, but it still doesn't feel right.

"This has been discussed at length, and consensus is that it would cause to many users to remove the defaults and complain that they are not restorable"

Most apps offer to "restore defaults". I suspect this might be done on a flexible basis, i.e. restore deleted defaults but don't delete user additions.

Removing the 'delete' menu altogether seems like hiding the problem - the playlist is still not deletable, and far too many users would like to only have the streams they actually listen to listed. It's just a matter of taste, but that's why we use amarok, after all :-)

Konqueror comes with predefined 'Network locations' (they point to ftp.kde.org), but it doesn't force anybody to keep them. Why should amarok force me t point to streams I don't want? I also can't edit Cool-Streams, by the way. It makes it feel like adware. In fact, I think it involuntarily makes it adware, strictly speaking.

Comment 3 min 2005-07-31 17:13:37 UTC
I correct the previous point. From a legal point of view it's not adware, since I can always edit and recompile (legally speaking). However, this only means that the playlist browser is not adware de jure, it still is de facto, beacuase removing the links would require some months of effort from most users (otherwise they won't know how to code)
Comment 4 Thiago Macieira 2005-07-31 20:29:24 UTC
> Sorry for reopening this, and I know it's an annoying gesture, but it still
> doesn't feel right.

If you know it's annoying, then don't do it.

Don't reopen WONTFIX bugs unless *you* will code the feature.
Comment 5 min 2005-07-31 22:21:38 UTC
Created attachment 12021 [details]
Add 'hide cool streams' configuration checkbox
Comment 6 min 2005-07-31 22:25:16 UTC
Created attachment 12022 [details]
add checkbox
Comment 7 min 2005-07-31 22:34:24 UTC
Created attachment 12023 [details]
don't show Cool-Streams if they are hidden
Comment 8 min 2005-07-31 22:36:23 UTC
Created attachment 12024 [details]
change to kcfg file
Comment 9 min 2005-07-31 22:40:03 UTC
Ok, coding the feature.

The four files above should do the following:

- add a checkbox in "Collection" config tab to allow user to hide Cool-Streams
- don't show Cool-Streams in playlist browser, if they're hidden

This should give the user the possibility to hide them without deleting them, which would make restoring possible at no extra cost (except one more check-box in the gui)

Also please don't chase me away if it's not good, this is the first time I look at kde codes, and the first time since quite a while when I use C++.
Comment 10 Seb Ruiz 2005-08-01 01:49:30 UTC
I'm not even going to bother with the effort of going through each one of those patches - could you create one large diff please against current svn?

thanks
Comment 11 Alexandre Oliveira 2005-08-01 03:04:07 UTC
And please, use the -u option when making patches.
Comment 12 min 2005-08-02 19:57:40 UTC
Ok, I'll come back when I know how to create a patch against current svn. Maybe suggest some less hackish implementation by that time too.

Closing this in the meanwhile to prevent buglist pollution (I do hope the evil hasn't already been done :) )
Comment 13 Ian Monroe 2005-08-02 21:04:44 UTC
To get a diff againist the current SVN, all you need to is type `svn diff`.
Comment 14 William Kendrick 2006-01-03 02:18:18 UTC
I discovered that I can delete streams I don't like my creating a new folder, dragging them there, and then deleting the folder.

Not providing a "Remove" or "Edit" for these stream entries seemed like a bug to me, though, which is why I hit "Report Bug" and found this bug. :^)
Comment 15 j15m21y 2006-12-05 22:26:15 UTC
Not being able to "restore defaults" seem a poor excuse for spamming our playlists.  Simply list the urls for the cool-streams on the amarok wiki and let people re-add them manually as they would any other station.  At a bare minimum let's get this checkbox idea implemented into the next version of Amarok.  Don't spoil an otherwise great app with "preconfigured spam".  
Comment 16 Martin Fabian Hohenberg 2007-01-27 09:56:31 UTC
Another point ... sometimes, webradios change their urls - currently, this affects Nectarine Demoscene Radio, whose "Cool Streams"-Entry is basically dead and polluting my playlist. Yes, I do have another folder with the new url in it, but this is annoying nontheless. Please make "Cool Streams" deletable.
Comment 17 Mark Kretschmann 2007-01-27 10:13:57 UTC
Please notify us of any dead streams. I'm updating the list regularly.

Gonna fix the Nectarine URL.