Bug 104485 - Option to disable HTML introduction
Summary: Option to disable HTML introduction
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 1.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-24 20:04 UTC by Charles Samuels
Modified: 2005-04-25 00:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Samuels 2005-04-24 20:04:34 UTC
Version:           1.0 (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-12)
OS:                Linux (i686) release 2.6.10

I think a lot of the time akregator takes to start up is taken by the html part with the "Welcome to Akregator 1.0" text. The text is all really quite useless and seems to almost double the startup time.

I think it should just start up selecting "All Feeds."  I just generally start up akregator, check for updates, and exit if there aren't any.

thanks
Comment 1 Eckhart Wörner 2005-04-24 20:22:50 UTC
Do you have a large number of articles? If so, it's probably the loading of the archive that takes so long. In this case, try a current CVS build (as there is a new archive backend that makes Akregator load faster (up to 10 times on my system).
Comment 2 Charles Samuels 2005-04-24 20:29:57 UTC
Yes, you're right, I should have researched it better.

I do however still think that welcome screen is rather useless and defaulting to "All Feeds" would be wise for usability, though.
Comment 3 Eckhart Wörner 2005-04-24 20:42:38 UTC
Well, the usability aspect still seems to be a good argument for it. I'll reopen it therefore.
Comment 4 Sashmit Bhaduri 2005-04-24 20:52:12 UTC
How about a link to "disable this screen for faster loading" in the startup screen like konqueror has?
Comment 5 Teemu Rytilahti 2005-04-25 00:28:12 UTC
CVS commit by rytilahti: 

Make it possible to disable introduction page. Should we add Konqi style "Display Introduction" into help menu, what do you think?
BUGS:104485


  M +10 -5     akregator_view.cpp   1.252
  M +16 -2     articleviewer.cpp   1.100
  M +1 -0      articleviewer.h   1.39


--- kdepim/akregator/src/akregator_view.cpp  #1.251:1.252
@@ -229,4 +229,7 @@ View::View( Part *part, QWidget *parent,
     }
 
+    KConfig *conf = Settings::self()->config();
+    conf->setGroup("General");
+    if(!conf->readBoolEntry("Disable Introduction", false)) {
     m_articleList->hide();
     m_searchBar->hide();
@@ -234,4 +237,5 @@ View::View( Part *part, QWidget *parent,
     m_tabs->setTitle(i18n("About"), m_mainTab);
     m_displayingAboutPage = true;
+    }
 
     m_fetchTimer = new QTimer(this);
@@ -721,4 +725,5 @@ void View::slotNodeSelected(TreeNode* no
             ActionManager::getInstance()->action("feed_remove")->setEnabled(false);
     }
+    
 }
 

--- kdepim/akregator/src/articleviewer.cpp  #1.99:1.100
@@ -38,4 +38,5 @@
 #include <kstandarddirs.h>
 #include <kshell.h>
+#include <kmessagebox.h>
 
 #include <libkdepim/kfileio.h>
@@ -194,8 +195,8 @@ void ArticleViewer::displayAboutPage()
             "Akregator collects the content for you.</p>"
             "<p>For more information about using Akregator, check the "
-            "<a href=\"%3\">Akregator website</a> as well as the <a href=\"%2\">Akregator handbook</a>.</p>"
+            "<a href=\"%3\">Akregator website</a> as well as the <a href=\"%2\">Akregator handbook</a>. If you don't want to see this page anymore, <a href=\"config:/disable_introduction\">click here</a>.</p>"
             "<p>We hope that you will enjoy Akregator.</p>\n"
             "<p>Thank you,</p>\n"
-            "<p style='margin-bottom: 0px'>&nbsp; &nbsp; The Akregator Team</p>")
+            "<p style='margin-bottom: 0px'>&nbsp; &nbsp; The Akregator Team</p>\n")
             .arg(AKREGATOR_VERSION) // Akregator version
             .arg("help:/akregator/index.html") // Akregator help:// URL
@@ -466,4 +467,17 @@ void ArticleViewer::keyPressEvent(QKeyEv
 }
 
+void ArticleViewer::urlSelected(const QString &url, int button, int state, const QString& _target, KParts::URLArgs args)
+{
+    if(url == "config:/disable_introduction") {
+        if(KMessageBox::questionYesNo( widget(), i18n("Are you sure you want to disable this introduction page?"), i18n("Disable Introduction Page") ) == KMessageBox::Yes) {
+            KConfig *conf = Settings::self()->config();
+            conf->setGroup("General");
+            conf->writeEntry("Disable Introduction", "true");
+        }
+    }
+    else
+        KHTMLPart::urlSelected(url, button, state, _target, args);
+}
+
 void ArticleViewer::slotPaletteOrFontChanged()
 {

--- kdepim/akregator/src/articleviewer.h  #1.38:1.39
@@ -88,4 +88,5 @@ namespace Akregator
             
             virtual void keyPressEvent(QKeyEvent* e);
+            virtual void urlSelected (const QString &url, int button, int state, const QString &_target, KParts::URLArgs args);
 
         private: