Bug 104169 - Kiosk restrictions are not applied completely to settings dialog
Summary: Kiosk restrictions are not applied completely to settings dialog
Status: RESOLVED UNMAINTAINED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 1.0
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-18 22:05 UTC by Eckhart Wörner
Modified: 2012-09-17 09:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eckhart Wörner 2005-04-18 22:05:20 UTC
Version:           1.0 (using KDE 3.4.0, Debian Package 4:3.4.0-0ubuntu3 (3.1))
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-8ubuntu2)
OS:                Linux (i686) release 2.6.10-5-386

Settings should be disabled when their correspondant setting in the akregatorrc file is marked immutable ([$i]). This affects the global fetch interval and the two font sliders.

If possible, the labels of disabled settings should also be grayed out - see also http://developer.kde.org/documentation/tutorials/kiosk/index.html (Figure 3). This would affect several labels in the settings dialog.
Comment 1 Heinrich Wendel 2005-06-23 23:18:38 UTC
the  global fetch interval seems to work fine here, any hint?
Comment 2 Heinrich Wendel 2005-06-27 13:52:32 UTC
SVN commit 429361 by lanius:

fix kiosk settings for font options
CCBUG: 104169

 M  +9 -1      configdialog.cpp  
 M  +4 -1      configdialog.h  
 M  +2 -2      settings_appearance.ui  


--- trunk/KDE/kdepim/akregator/src/configdialog.cpp #429360:429361
@@ -35,6 +35,8 @@
 #include "settings_archive.h"
 #include "settings_browser.h"
 #include "settings_general.h"
+#include <qslider.h>
+#include <qlabel.h>
 
 namespace Akregator
 {
@@ -43,11 +45,13 @@
 {
     addPage(new SettingsGeneral(this, "General"), i18n("General"), "package_settings");
     addPage(new SettingsArchive(this, "Archive"), i18n("Archive"), "package_settings");
-    addPage(new SettingsAppearance(this, "Appearance"), i18n("Appearance"), "fonts");
+    m_settingsAppearance = new SettingsAppearance(this, "Appearance");
+    addPage(m_settingsAppearance, i18n("Appearance"), "fonts");
     addPage(new SettingsBrowser(this, "Browser"), i18n("Browser"), "package_network");
     m_settingsAdvanced = new SettingsAdvanced(this, "Advanced");
     addPage(m_settingsAdvanced, i18n("Advanced"), "package_network");
     m_settingsAdvanced->selectFactory(Settings::archiveBackend());
+    m_config = config;
 }
 
 void ConfigDialog::updateSettings()
@@ -59,6 +63,10 @@
 void ConfigDialog::updateWidgets()
 {
     m_settingsAdvanced->selectFactory(Settings::archiveBackend());
+    m_settingsAppearance->slider_minimumFontSize->setDisabled(m_config->isImmutable("MinimumFontSize"));
+    m_settingsAppearance->slider_mediumFontSize->setDisabled(m_config->isImmutable("MediumFontSize"));
+    m_settingsAppearance->lbl_MinimumFontSize->setDisabled(m_config->isImmutable("MinimumFontSize"));
+    m_settingsAppearance->lbl_MediumFontSize->setDisabled(m_config->isImmutable("MediumFontSize"));
     KConfigDialog::updateSettings();
 }
         
--- trunk/KDE/kdepim/akregator/src/configdialog.h #429360:429361
@@ -30,6 +30,7 @@
 namespace Akregator {
 
 class SettingsAdvanced;
+class SettingsAppearance;
 
 class ConfigDialog : public KConfigDialog
 {
@@ -47,7 +48,9 @@
         virtual void updateWidgets();
 
     private:
-        SettingsAdvanced* m_settingsAdvanced;       
+        KConfigSkeleton* m_config;
+        SettingsAdvanced* m_settingsAdvanced;
+        SettingsAppearance* m_settingsAppearance;
         
 };
 
--- trunk/KDE/kdepim/akregator/src/settings_appearance.ui #429360:429361
@@ -36,7 +36,7 @@
                 </property>
                 <widget class="QLabel" row="0" column="0" rowspan="1" colspan="2">
                     <property name="name">
-                        <cstring>textLabel1_2</cstring>
+                        <cstring>lbl_MinimumFontSize</cstring>
                     </property>
                     <property name="text">
                         <string>Minimum font size:</string>
@@ -75,7 +75,7 @@
                 </widget>
                 <widget class="QLabel" row="2" column="0" rowspan="1" colspan="2">
                     <property name="name">
-                        <cstring>textLabel2</cstring>
+                        <cstring>lbl_MediumFontSize</cstring>
                     </property>
                     <property name="text">
                         <string>Medium font size:</string>
Comment 3 Heinrich Wendel 2005-06-27 13:54:52 UTC
the global fetch interval is a different bug. the kiosk restrictions are applied, so you can't change anything although it is enabled. the problem is a bigger one that affects other options and other applications as well. it is related to connecting toggled(bool) to setEnabled(bool).
Comment 4 Adrián Chaves (Gallaecio) 2012-09-17 06:30:29 UTC
From the last comment, I assume this is an upstream issue, not Akregator’s. Can this be closed?
Comment 5 Myriam Schweingruber 2012-09-17 09:46:35 UTC
Closing as outdated.