Summary: | loading a m3u playlist hangs Amarok, and fails | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Nick Steeves <nsteeves> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.2-beta4 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Nick Steeves
2005-02-02 09:20:48 UTC
How many items in this playlist? I believe the hang would be temporary. CVS commit by mhowell: Don't hang if user loads a playlist containing 3-4000 non existant URLs BUG: 98389 M +7 -2 enginecontroller.cpp 1.112 --- kdeextragear-1/amarok/src/enginecontroller.cpp #1.111:1.112 @@ -328,8 +328,13 @@ void EngineController::play( const MetaB else some_kind_of_failure: + //NOTE now we don't do next() at all + // say the user has a 4000 item playlist with all URLs in that playlist + // being bad, amaroK will appear to freeze. We need to either stat files in + // the background or not call next() more than 5 times in a row //don't do for repeatPlaylist() as it can produce a freeze //FIXME -> mxcl - if ( !AmarokConfig::repeatPlaylist() ) - next(); + //if ( !AmarokConfig::repeatPlaylist() ) + // next() + ; } It's just a normal m3u playlist with 71 items. The hang isn't permanent--20 sec or so. It is impossible to play any music from a playlist loaded from disk, where the files reside on disk. That is why I said "hangs and fails", rather then "hangs indefinitely". I think this may be fixed now. Can you try again with CVS HEAD? This fixes the m3u playlist loading but, but somewhere in CVS HEAD, double clicking on "100 random songs" broke. Dragging'n Dropping it to the playlist is ok, but double clicking isn't. Weird eh? If you don't think that the new "100 random songs" playlist bug is related to the recent m3u fixes then bug 98389 (this bug) is fixed! Thanks. Yes, double-clicking currently does not work. Thanks for responding, closing bug. |