Summary: | Joining +k Channels does not work for me | ||
---|---|---|---|
Product: | [Applications] konversation | Reporter: | Christian Herenz <herenz9> |
Component: | general | Assignee: | argonel <argonel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Christian Herenz
2005-01-30 16:46:00 UTC
As discussed on IRC. No, this is a valid bug. You said this is a server bug. And we don't have to workaround server bugs. Some servers delete multiple adjacent delimeters, some don't. This is not specified in the RFC, so we must accomodate both. its really an ambiguity in the specification. rfc1459 is probably one of the worst RFCs ever written. (argonel) the join line at the moment works on some networks but not on the one i am using, so there is need of a join line that works on all networks, i think. using dummy keys e.g. as you suggested or always putting the key protected channels on top of the list. CVS commit by psn: Insert a fake key to make +k channels work on some servers BUG:98207 M +1 -1 server.cpp 1.461 --- kdeextragear-2/konversation/konversation/server.cpp #1.460:1.461 @@ -212,5 +212,5 @@ void Server::init(KonversationMainWindow channels += (*it).name(); - keys += (*it).password(); + keys += ((*it).password().isEmpty() ? "''" : (*it).password()); } commit 791b86edffedf2e7c5b18928a5225da843f1b367 Author: Peter Simonsson <peter.simonsson@gmail.com> Date: Sat Apr 2 20:58:20 2005 +0000 Insert a fake key to make +k channels work on some servers BUG:98207 svn path=/trunk/kdeextragear-2/konversation/; revision=402715 diff --git a/konversation/server.cpp b/konversation/server.cpp index 61dd182..b2a946a 100644 --- a/konversation/server.cpp +++ b/konversation/server.cpp @@ -211,7 +211,7 @@ void Server::init(KonversationMainWindow* mainWindow, const QString& nick, const } channels += (*it).name(); - keys += (*it).password(); + keys += ((*it).password().isEmpty() ? "''" : (*it).password()); } setAutoJoinChannel(channels); |