Bug 97694

Summary:	"Print Format" page in kprinter: "Pages per Sheet", enabled radio button jumps upon "Save"
Product:	[Applications] kdeprint	Reporter:	Kurt Pfeifle <pfeifle>
Component:	general	Assignee:	KDEPrint Devel Mailinglist <kde-print-devel>
Status:	CLOSED FIXED
Severity:	normal	CC:	jlayt
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description Kurt Pfeifle 2005-01-23 02:20:34 UTC

Version:           3.4cvs (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 3.3.3 (SuSE Linux) 
OS:                Linux

(the bug is likely in kpqtpage.cpp)

How to reproduce:

* start kprinter, select "Print to PDF", click on "Properties..."
* go to "Print Format" page
* click on "other", click on "Save" --> notice it jumps to "4"
* click on "1", click on "Save" --> notice it jumps to "other"

It looks like the correct value *IS* saved, though. But to see their selection jumping is very confusing for users

BTW -- I am not sure how "other" should be handled here...

I know we handle this feature through the use of the (external) psnup (and assorted psnup.xml file). But maybe we should put an explanation beside the button, telling the user to configure 8- and 16-up on the "Filter" tab page? (I will put it into WhatsThis with enough verbosity)

Comment 1 Cristian Tibirna 2005-09-27 07:01:42 UTC

SVN commit 464359 by tibirna:

don't jump to "Other" when "1" chosen in "Pages per sheet". I'll still
have to look deeper at this code in the future (rewrite?)
BUG:97694


 M  +17 -11    kpqtpage.cpp  


--- branches/KDE/3.5/kdelibs/kdeprint/kpqtpage.cpp #464358:464359
@@ -108,7 +108,7 @@
                         " <li> <b>Portrait.</b>.Portrait is the default setting. </li> "
                         " <li> <b>Landscape.</b> </li> "
                         " </ul> "
-                        " The icon changes according to your selection." 
+                        " The icon changes according to your selection."
 			" </qt>" );
 	setTitle(i18n("Print Format"));
 
@@ -270,16 +270,22 @@
 	ID = NUP_1;
 	if (opts["_kde-filters"].find("psnup") != -1)
 	{
-		ID = opts["_kde-psnup-nup"].toInt();
-		if (ID == 1 || ID == 2 || ID == 4)
-		{
-			if (ID == 4) ID = 3;
-			ID--;
-		}
-		else
-		{
-			ID = NUP_OTHER;
-		}
+               if (opts.contains("_kde-psnup-nup")) {
+                       ID = opts["_kde-psnup-nup"].toInt();
+                       if (ID == 1 || ID == 2 || ID == 4)
+                       {
+                               if (ID == 4) ID = 3;
+                               ID--;
+                       }
+                       else
+                       {
+                               ID = NUP_OTHER;
+                       }
+               }
+               else
+               {
+                       ID = NUP_1;
+               }
 	}
 	m_nupbox->setButton(ID);
 	slotNupChanged(ID);

Comment 2 John Layt 2008-12-31 17:58:25 UTC

Closing old Resolved status bug.