Bug 96655

Summary:	password strength meter stays at zero
Product:	[Frameworks and Libraries] kdelibs	Reporter:	Steffen Müthing <steffenm>
Component:	general	Assignee:	Andrew Coles <andrew.i.coles>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	patch for KPasswordDialog revised patch for KPasswordDialog

Description Steffen Müthing 2005-01-09 20:11:24 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

The password strength meter in the New Password Dialog (KPasswordDialog) has stopped working for me for quite some time now. It requires an insane amount of characters of any type (uppercase, lowercase, digits etc.) to show any movement at all.
After looking at the code I discovered the reason: By default, KPasswordDialog assumes a maximum password length of 199 and bases the password strength calculation on the fact that only a password of nearly that length is safe.
I created a patch that introduces a new property for KPasswordDialog, reasonablePasswordLength, which is now used for password strength calculation and defaults to 1. This gives a password strength of 100% with a password of about 8 characters containing several digits and symbols.

Comment 1 Steffen Müthing 2005-01-09 20:12:04 UTC

Created attachment 9006 [details]
patch for KPasswordDialog

Comment 2 Andrew Coles 2005-01-14 22:22:05 UTC

OK, sounds like a good idea.  Would you be happy if the default reasonable password length was 8 by default instead of 1, dropping the extra conditional to use 8 if the reasonable length is still the default (1)?

Comment 3 Steffen Müthing 2005-01-15 15:26:27 UTC

Created attachment 9104 [details]
revised patch for KPasswordDialog

I agree. The conditional only needlessy complicates the code. Here is the
revised patch.

Comment 4 Andrew Coles 2005-01-19 13:09:53 UTC

CVS commit by coles: 



CCMAIL: 96655@bugs.kde.org

Added 'reasonable password length' option, used for calculating password
strengths - previously, all strengths were calculated with respect to the maximum
password length (200) unless a maximum length was specified. The default reasonable
length is 8.

Many thanks to Steffen M

Comment 5 Andrew Coles 2005-01-19 13:11:43 UTC

*** Bug has been marked as fixed ***.