Bug 96050

Summary:	changing the default preview size break previews
Product:	kcontrol	Reporter:	Giovanni Venturi <giovanni>
Component:	kcmkonq	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	wendigo3
Priority:	NOR
Version:	2.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Giovanni Venturi 2004-12-31 00:43:35 UTC

Version:           2.0 (using KDE 3.3.2, compiled sources)
Compiler:          gcc version 3.3.4
OS:                Linux (i686) release 2.6.10

If I change the default size of the files preview than I lost all files preview if I let unchanged I got preview obviously. I think the problem is not set the default protocol for preview. They forgot to set it by default.

Comment 1 Giovanni Venturi 2004-12-31 00:47:17 UTC

CVS commit by gianni: 

fix bug #96050
BUG: 96050


  M +6 -1      previews.cpp   1.23


--- kdebase/kcontrol/konq/previews.cpp  #1.22:1.23
@@ -165,4 +165,9 @@ void KPreviewOptions::load(bool useDefau
     for ( ; it.current() ; ++it ) {
         QString protocol( it.current()->text() );
+        if ( ( protocol == "file" ) && ( !group.hasKey ( protocol ) ) )
+          // file should be enabled in case is not defined because if not so
+          // than preview's lost when size is changed from default one
+          it.current()->setOn( true );
+        else
         it.current()->setOn( group.readBoolEntry( protocol, false ) );
     }

Comment 2 wendigo 2005-04-07 14:57:32 UTC

The same thing happens if you add another the media protocol to the preview options. It breaks the previews. I don't know if this has been fixed too.

Comment 3 wendigo 2005-04-07 14:58:00 UTC

The same thing happens if you add the media protocol to the preview options. It breaks the previews. I don't know if this has been fixed too.

Comment 4 Giovanni Venturi 2005-04-07 15:21:57 UTC

Can you explain better step by step, so I can fix it too.