Summary: | display error when reading full story on tweakers.net | ||
---|---|---|---|
Product: | [Applications] akregator | Reporter: | Bart Cerneels <shanachie> |
Component: | general | Assignee: | George Staikos <staikos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.0-beta8 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | screenshot of akregator when reading full story on tweakers.net |
Description
Bart Cerneels
2004-12-02 15:59:18 UTC
Created attachment 8521 [details]
screenshot of akregator when reading full story on tweakers.net
Javascript is disabled in aKregator by design (I guess for security reasons). setJScriptEnabled(false); setJavaEnabled(true); setMetaRefreshEnabled(true); setPluginsEnabled(true); setDNDEnabled(true); setAutoloadImages(true); setStatusMessagesEnabled(true); <----- I think this should be disabled Now, I don't see any security issues with javascript since they're self-contained KHTML parts loading from the web. It's not like e-mail where the content is pushed to you in a sense. Any opinions? I chose to watch this feed, that meens I trust the people who publish it. So if activating javascript solves this bug I'm for it. Ok I have a solution. I think javascript should be enabled for clicked links, but not in the viewer for data from the RSS feed itself. I will change it accordingly. CVS commit by staikos: Enable JavaScript for browser panes, but disable it for the article viewer. The article viewer is a "push" so we shouldn't allow it, but the clicked links tabs should support it since they're user-triggered actions to view a web page. BUG: 94281 M +1 -0 akregator_view.cpp 1.182 M +13 -2 viewer.cpp 1.28 M +1 -0 viewer.h 1.16 --- kdenonbeta/akregator/src/akregator_view.cpp #1.181:1.182 @@ -202,4 +202,5 @@ aKregatorView::aKregatorView( aKregatorP m_articleViewer = new ArticleViewer(m_articleSplitter, "article_viewer"); + m_articleViewer->setSafeMode(); // disable JS, Java, etc... connect( m_articleViewer, SIGNAL(urlClicked(const KURL&, bool)), --- kdenonbeta/akregator/src/viewer.cpp #1.27:1.28 @@ -31,6 +31,5 @@ Viewer::Viewer(QWidget *parent, const ch : KHTMLPart(parent, name), m_url(0) { - // to be on a safe side - setJScriptEnabled(false); + setJScriptEnabled(true); setJavaEnabled(true); setMetaRefreshEnabled(true); @@ -207,4 +206,16 @@ void Viewer::slotPrint( ) } + +void Viewer::setSafeMode() +{ + setJScriptEnabled(false); + setJavaEnabled(false); + setMetaRefreshEnabled(false); + setPluginsEnabled(false); + setDNDEnabled(true); + setAutoloadImages(true); + setStatusMessagesEnabled(false); +} + #include "viewer.moc" --- kdenonbeta/akregator/src/viewer.h #1.15:1.16 @@ -37,4 +37,5 @@ namespace Akregator void slotScrollDown(); void slotPrint(); + void setSafeMode(); signals: |