Summary: | ftp:// fish:// and other password protected protocols show password in address bar | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Ryan Sinn <ryan> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | carstenlohrke |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | passwords shown in location selection dropdown |
Description
Ryan Sinn
2004-11-23 12:39:16 UTC
Created attachment 8397 [details]
passwords shown in location selection dropdown
you can refer to the original bug I filled on KONQ for their solution/patch. http://bugs.kde.org/show_bug.cgi?id=82281 AFAICS, all applications displaying the URL in the title bar would suffer, as well as apps using KRecentFile. Would it be acceptable to create a generic solution to this, for example a) make KRecentFile not store the password (and maybe username?), and b) make prettyURL not display password/username either, or eventually replace it by 'username:[hidden]'? Uhm, david, are you reading this? Fixed in cvs: Don't show a password in the combobox history (remove it, so that later usage will result in a password prompt M +11 -6 katefileselector.cpp 1.48 --- kdebase/kate/app/katefileselector.cpp #1.47:1.48 @@ -379,7 +379,12 @@ void KateFileSelector::cmbPathActivated( void KateFileSelector::cmbPathReturnPressed( const QString& u ) { + kdDebug()<<"opening url "<<u<<endl; + KURL typedURL( u ); + if ( typedURL.hasPass() ) + typedURL.setPass( QString::null ); + QStringList urls = cmbPath->urls(); - urls.remove( u ); - urls.prepend( u ); + urls.remove( typedURL.url() ); + urls.prepend( typedURL.url() ); cmbPath->setURLs( urls, KURLComboBox::RemoveBottom ); dir->setFocus(); |