Bug 89785

Summary: juk crashes on using dcop call: juk Collection removeTrack
Product: [Applications] juk Reporter: Hans Dembinski <mr_smith>
Component: generalAssignee: Scott Wheeler <wheeler>
Status: RESOLVED FIXED    
Severity: crash    
Priority: NOR    
Version: 2.1   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Hans Dembinski 2004-09-18 23:21:58 UTC
Version:           2.1 (using KDE 3.3.0,  (3.1))
Compiler:          gcc version 3.3.4 (Debian 1:3.3.4-9)
OS:                Linux (i686) release 2.6.8.1

Hi,

on my system, Juk crashes very reliably on using the dcop call in the command shell:
dcop Juk Collection removeTrack MyPlaylist OnOfMyFiles
Juk crashes instantly without the KDE Bug Handler and dcop returns "call failed".

Regards,
HD
Comment 1 Michael Pyne 2004-09-19 05:47:18 UTC
CVS commit by mpyne: 

Fix bug 89785 (JuK crashes on DCOP call), which was caused by not specifying the correct overloaded function call.

CCMAIL:89785@bugs.kde.org


  M +1 -1      jukIface.h   1.16


--- kdemultimedia/juk/jukIface.h  #1.15:1.16
@@ -18,5 +18,5 @@ k_dcop:
     virtual void remove() = 0;
 
-    virtual void removeTrack(const QString &playlist, const QString &file) { removeTrack(playlist, file); }
+    virtual void removeTrack(const QString &playlist, const QString &file) { removeTrack(playlist, QStringList(file)); }
     virtual void removeTrack(const QString &playlist, const QStringList &files) = 0;
 


Comment 2 Michael Pyne 2004-09-19 05:50:48 UTC
CVS commit by mpyne: 

Backport fix for bug 89785 (JuK crashes on DCOP call) to KDE 3.3.

CCMAIL:89785-done@bugs.kde.org


  M +1 -1      jukIface.h   1.15.2.1


--- kdemultimedia/juk/jukIface.h  #1.15:1.15.2.1
@@ -18,5 +18,5 @@ k_dcop:
     virtual void remove() = 0;
 
-    virtual void removeTrack(const QString &playlist, const QString &file) { removeTrack(playlist, file); }
+    virtual void removeTrack(const QString &playlist, const QString &file) { removeTrack(playlist, QStringList(file)); }
     virtual void removeTrack(const QString &playlist, const QStringList &files) = 0;