Summary: | kdnetwork 3.3.0 fails to build when arts support is off | ||
---|---|---|---|
Product: | kwireless | Reporter: | Steve <steve> |
Component: | general | Assignee: | Stefan Winter <swinter> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caleb, rok.papez, Sascha-bugs.kde.org |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch to disable arts support in wifi if --without-arts is passed |
Description
Steve
2004-09-01 00:58:28 UTC
KWifi seems to be part of kwireless, so moving the bug there... Also be careful that patches should not be entered as simple text but attached to the bug report (which you can do once the bug report is created), otherwise they could get corrupted very easily. Have a nice day! Well, your patch seems to resolve the issue, BUT it completely removes a feature that was requested by several users. Namely: emit beeps in varying frequencies (depending on signal strength) when you are in range of a wireless network. Sorry, I won´t apply that. One could think of a set of #DEFINE statements to exclude the code in question when arts is not present, but no altogether removal. I'd agree with that, you can alter the configure script to add a -DARTS or -DNARTS (and place the removals in the patch under a IFDEF ARTS and the additions under IFNDEF ARTS or IFDEF NARTS. The patch I applied is really just a cheap hack, it works on gentoo because there is a use flag for arts, so in the ebuild one can just check to see if its a -arts situation, you could get the same result (only having the patch take effect if arts is disabled on the ./configure options) by placing the contents of the patch in each file in a ifdef statment. Steve Created attachment 7586 [details]
Patch to disable arts support in wifi if --without-arts is passed
Should apply to HEAD cleanly - just needs tested.
Hi, I´ll check your patch ASAP (i.e. not before another 26 hours, until I have completed my diploma). Stefan Any word on this? I'd like to get this fix committed this for upcoming releases. It's already too late for 3.3.1. Yes, I looked into it lately. It fixes compilation --without-arts alright, but it fails to build when it is present. Seems like HAS_ARTS is not set correctly in the build envirmonment, the -l phrases are never set, even if they should be. I am not sure if the problem is within your patch, but you could halp me if you'd double-check this. The bug was just fixed in KDE CVS in the HEAD branch and will be available in KDE 3.4. I´ll wait some time to see if everything works flawlessly (some changes in the patch were necessary) and will then probably backport it to KDE_3_3_BRANCH. The backport for 3.3.x branch is in place now. |