Bug 88415

Summary:	should be possible to alter operation parameters
Product:	[Applications] umbrello	Reporter:	Albert Cervera Areny <albert>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Allow moving operation properties

Description Albert Cervera Areny 2004-08-30 01:01:43 UTC

Version:            (using KDE KDE 3.3.0)
Installed from:    Compiled From Sources
OS:                Linux

When adding parameters to an operation it is not possible to alter their order so you have to remove them first and add them again.

Comment 1 Albert Cervera Areny 2004-08-30 01:19:04 UTC

Created attachment 7352 [details]
Allow moving operation properties

The patch is agains current CVS. It adds a couple of buttons to allow moving
parameters of an operation up and down.

Comment 2 Jonathan Riddell 2004-09-01 00:43:28 UTC

Patch looks good, I've made a couple of modifications to make the buttons the same as for the other dialogues.

 http://muse.19inch.net/~jr/tmp/move-paramaters.diff

However it causes a crash on a diagram with a class plus operation plus parameters which has been saved then loaded.  No idea why, no backtrace out of it.

Comment 3 Albert Cervera Areny 2004-09-02 00:06:38 UTC

Now that I remember, I also detected one error, but don't think it is of 
because of the patch. If when you create a property, give it a name. The name 
give is shown in the parameter list but if you try to edit it again you won't 
be able! That is because the name given isn't really stored (newparameter_1 
is saved instead).

I tried to find what was the reason, but wasn't able...

A Dimecres 01 Setembre 2004 00:43, Jonathan Riddell va escriure:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=88415
>
>
>
>
> ------- Additional Comments From jr jriddell org  2004-09-01 00:43 -------
> Patch looks good, I've made a couple of modifications to make the buttons
> the same as for the other dialogues.
>
>  http://muse.19inch.net/~jr/tmp/move-paramaters.diff
>
> However it causes a crash on a diagram with a class plus operation plus
> parameters which has been saved then loaded.  No idea why, no backtrace out
> of it.

Comment 4 Oliver Kellogg 2004-10-02 21:35:15 UTC

Jonathan Riddell wrote:
> However it causes a crash on a diagram with a class
> plus operation plus parameters which [...]

I applied the patch but cannot confirm the crash.
Since there has been a number of crash fixes lately,
could you try again please?

Earlier, Albert Cervera Areny wrote:
> If when you create a property, give it a name. The name 
> given is shown in the parameter list but if you try to
> edit it again you won't be able! That is because the name
> given isn't really stored (newparameter_1 is saved instead).

Oops, yes. It's fixed. Thanks for reporting.