Summary: | View Source: Headers incorrectly detected in message body (bold) | ||
---|---|---|---|
Product: | [Applications] kmail | Reporter: | David Förster <david> |
Component: | messageviewer | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugreports, drx, hughwarrington, jo, roman.cheplyaka |
Priority: | NOR | Keywords: | triaged |
Version: | 1.10.90 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
David Förster
2004-08-28 01:45:28 UTC
*** Bug 113586 has been marked as a duplicate of this bug. *** *** Bug 117451 has been marked as a duplicate of this bug. *** *** Bug 128251 has been marked as a duplicate of this bug. *** It's no wonder considering that the highlighting code is effectively five lines and only looks at one message line at a time. It is fairly simple to look for the first blank line that marks the end of the top level message header. That, however, would destroy the formatting of headers in multipart/* body parts and attached messages. The correct way would probably be to traverse the DwMessage structure, to the extent that it is possible to get the original raw text back, which I doubt even if public Preamble() and Epilogue() methods were added to DwBody. But if it can be done, bug 97665 can be fixed in the process. As a heuristic approach, we could assume that any line that could be a MIME boundary is one. We then start parsing headers until the next blank line, except if a Content-Type: message/* field was found, in which case parsing continues. *** Bug 127469 has been marked as a duplicate of this bug. *** See also bug 152707. *** Bug 160575 has been marked as a duplicate of this bug. *** Still reproducable with kmail 1.10.90 (svn r860337). SVN commit 960620 by jtamate: BUG: 88271 BUG: 152707 Use the right regular expresion to check for mail headers. Also, use a mini ad-hoc state machine to not treat all that looks like headers as headers. When a blank line is found, it is supposed to start a body part, until a header with Content- is found. M +28 -5 mailsourceviewer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=960620 SVN commit 961651 by tmcguire: Backport r960620 by jtamate from trunk to the 4.2 branch: CCBUG: 88271 CCBUG: 152707 Use the right regular expresion to check for mail headers. Also, use a mini ad-hoc state machine to not treat all that looks like headers as headers. When a blank line is found, it is supposed to start a body part, until a header with Content- is found. M +28 -5 mailsourceviewer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=961651 |