Summary: | hang when editing a plugin | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | Netterfield <netterfield> |
Component: | general | Assignee: | George Staikos <staikos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Netterfield
2004-08-12 05:10:40 UTC
Appears to be a problem in CVS still. Investigating. Are these filters exceedingly slow for everyone, or just me? They seem to take minutes to compute on a relatively small number of samples. Definitely deadlock. CVS commit by staikos: correct locking for the edit case CCMAIL: 87013-done@bugs.kde.org M +1 -4 kstplugindialog_i.cpp 1.82 --- kdeextragear-2/kst/kst/kstplugindialog_i.cpp #1.81:1.82 @@ -456,18 +456,16 @@ bool KstPluginDialogI::edit_I() { DP->inputScalars().clear(); - DP->writeUnlock(); // Save the vectors and scalars if (!saveInputs(DP, pPtr)) { KMessageBox::sorry(this, i18n("There is an error in the plugin you " "entered. Please fix it.")); + DP->writeUnlock(); return false; } - DP->writeLock(); if (pitem >= 0 && PluginCombo->count() > 0) { DP->setPlugin(pPtr); } - DP->writeUnlock(); if (!saveOutputs(DP, pPtr)) { KMessageBox::sorry(this, i18n("There is an error in the plugin you " @@ -476,5 +474,4 @@ bool KstPluginDialogI::edit_I() { } - DP->writeLock(); if (!DP->isValid()) { KMessageBox::sorry(this, i18n("There is an error in the plugin you entered. Please fix it.")); |