Bug 85870

Summary: Contacts with association to address book entry have graphical error in cotact properties
Product: [Applications] kopete Reporter: Jure Repinc <jlp>
Component: generalAssignee: Kopete Developers <kopete-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: janis.blechert
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Contact properties bug

Description Jure Repinc 2004-07-24 16:11:12 UTC
Version:           0.8.922 (using KDE Devel)
Installed from:    Compiled sources
Compiler:          GCC 3.4.1 
OS:                Linux

In some of the contact properties I have noticed a graphical error in the upper left corner of the dialog box. I'll attach a screenshot of the problem. Later I found out that this only happens to contacts that are associated with Address book entry.
Comment 1 Jure Repinc 2004-07-24 16:13:05 UTC
Created attachment 6821 [details]
Contact properties bug

Check out the graphical problem in the upper left corner of the dialog.
Comment 2 Richard Smith 2004-07-31 01:06:40 UTC
Seen this here too. It's not a drawing bug, there's an actual widget there.
Comment 3 Richard Smith 2004-08-17 01:31:32 UTC
CVS commit by lilachaze: 

KopeteAddressBookExport isn't a widget
Matt: If you get tired of backporting, tell me and I'll get myself a BRANCH
tree...
CCMAIL: matt@matt.rogers.name
CCMAIL: 85870@bugs.kde.org


  M +3 -2      kopeteaddrbookexport.cpp   1.3
  M +2 -1      kopeteaddrbookexport.h   1.2


--- kdenetwork/kopete/kopete/contactlist/kopeteaddrbookexport.cpp  #1.2:1.3
@@ -35,7 +35,8 @@
 #include "kopeteaddrbookexportui.h"
 
-KopeteAddressBookExport::KopeteAddressBookExport( QWidget *parent, KopeteMetaContact *mc ) : QWidget( parent )
+KopeteAddressBookExport::KopeteAddressBookExport( QWidget *parent, KopeteMetaContact *mc ) : QObject( parent )
 {
         // instantiate dialog and populate widgets
+        mParent = parent;
         mAddressBook = KABC::StdAddressBook::self();
         mMetaContact = mc;
@@ -173,5 +174,5 @@ int KopeteAddressBookExport::showDialog(
                 numWorkPhones = 0;
                 numMobilePhones = 0;
-                mDialog = new KDialogBase( this, "addressbookexportdialog", true, i18n("Export to Address Book"), KDialogBase::Ok|KDialogBase::Cancel );
+                mDialog = new KDialogBase( mParent, "addressbookexportdialog", true, i18n("Export to Address Book"), KDialogBase::Ok|KDialogBase::Cancel );
                 mUI = new AddressBookExportUI( mDialog );
                 mDialog->setMainWidget( mUI );

--- kdenetwork/kopete/kopete/contactlist/kopeteaddrbookexport.h  #1.1:1.2
@@ -34,5 +34,5 @@ class KListBox;
 class KComboBox;
 
-class KopeteAddressBookExport : public QWidget
+class KopeteAddressBookExport : public QObject
 {
 public:
@@ -83,4 +83,5 @@ protected:
         
         // the GUI
+        QWidget *mParent;
         KDialogBase * mDialog;
         QPixmap mAddrBookIcon;


Comment 4 Matt Rogers 2004-08-17 02:24:23 UTC
CVS commit by mattr: 

Backport the fix for 85870. This should be in KDE 3.3.1

CCMAIL: 85870-done@bugs.kde.org


  M +3 -2      kopeteaddrbookexport.cpp   1.2.2.1
  M +2 -1      kopeteaddrbookexport.h   1.1.2.1


--- kdenetwork/kopete/kopete/contactlist/kopeteaddrbookexport.cpp  #1.2:1.2.2.1
@@ -35,7 +35,8 @@
 #include "kopeteaddrbookexportui.h"
 
-KopeteAddressBookExport::KopeteAddressBookExport( QWidget *parent, KopeteMetaContact *mc ) : QWidget( parent )
+KopeteAddressBookExport::KopeteAddressBookExport( QWidget *parent, KopeteMetaContact *mc ) : QObject( parent )
 {
         // instantiate dialog and populate widgets
+        mParent = parent;
         mAddressBook = KABC::StdAddressBook::self();
         mMetaContact = mc;
@@ -173,5 +174,5 @@ int KopeteAddressBookExport::showDialog(
                 numWorkPhones = 0;
                 numMobilePhones = 0;
-                mDialog = new KDialogBase( this, "addressbookexportdialog", true, i18n("Export to Address Book"), KDialogBase::Ok|KDialogBase::Cancel );
+                mDialog = new KDialogBase( mParent, "addressbookexportdialog", true, i18n("Export to Address Book"), KDialogBase::Ok|KDialogBase::Cancel );
                 mUI = new AddressBookExportUI( mDialog );
                 mDialog->setMainWidget( mUI );

--- kdenetwork/kopete/kopete/contactlist/kopeteaddrbookexport.h  #1.1:1.1.2.1
@@ -34,5 +34,5 @@ class KListBox;
 class KComboBox;
 
-class KopeteAddressBookExport : public QWidget
+class KopeteAddressBookExport : public QObject
 {
 public:
@@ -83,4 +83,5 @@ protected:
         
         // the GUI
+        QWidget *mParent;
         KDialogBase * mDialog;
         QPixmap mAddrBookIcon;


Comment 5 Richard Smith 2004-10-06 22:40:42 UTC
*** Bug 89562 has been marked as a duplicate of this bug. ***