Bug 81514

Summary:	Tabs "Text only" mode unavailable
Product:	[Applications] konsole	Reporter:	adgor <adgor>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	CVS
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description adgor 2004-05-13 17:35:38 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc-3.3.3 gcc-3.4.0 
OS:                Linux

If I choose the "Text only" option from "Tab options" tabbar contekst menu - the setting is available only while the tab with session is inactive. Clicking on the tab to activate it makes the icon appear before the tab text. These icons remain shown all the time after that, however "Text only" option in "Tab options" menu is still selected.

Comment 1 Kurt Hindenburg 2004-05-14 08:13:36 UTC

Tested on 3.2.2 with 4 tabs open.  All 3 'tab options' work for me.

Comment 2 Stephan Binner 2004-05-15 10:25:13 UTC

> Compiler:          gcc-3.3.3 gcc-3.4.0

Cool compiler version, but what KDE version?

Comment 3 adgor 2004-05-15 11:31:15 UTC

> Version:            (using KDE Devel)

KDE cvs head - ver. 3.2.90 (the problem appears since last two months).

Comment 4 zblob 2004-06-04 07:03:48 UTC

Confirmed with kde cvs of 20040603, new tabs have an icon next to the text, and clicking on a tab brings the icon back.

Comment 5 Kurt Hindenburg 2004-06-04 07:46:16 UTC

Ahh, I see.

1. Select Text-only - all tabs correctly go to text-only tab.
2. Change to any other tab - icon returns (text-only still selected).

Icon & Text and Icon-only work as expected.

Until this bug report I never knew there was a 'Tab option'  Is there some 
reason this is not in the Settings menu?

Comment 6 Kurt Hindenburg 2004-06-04 08:38:18 UTC

Try this patch.  On another note, I notice that when the tab arrows are visible, left-clicking over the 'new-tab' button doesn't popup the 'Tab ...' menu.  Oh well, another bug...

Index: konsole.cpp
===================================================================
RCS file: /home/kde/kdebase/konsole/konsole/konsole.cpp,v
retrieving revision 1.462
diff -u -p -r1.462 konsole.cpp
--- konsole.cpp 24 May 2004 11:12:45 -0000      1.462
+++ konsole.cpp 4 Jun 2004 06:37:01 -0000
@@ -1925,6 +1925,8 @@ void Konsole::createSessionTab(TEWidget

 QIconSet Konsole::iconSetForSession(TESession *session) const
 {
+  if (m_tabViewMode == ShowTextOnly)
+    return QIconSet();
   return SmallIconSet(session->isMasterMode() ? "remote" : session->IconName());
 }

Comment 7 Stephan Binner 2004-06-05 20:58:28 UTC

Patch looks fine, please commit.
I cannot reproduce the arrow bug you're talking about.

Comment 8 Kurt Hindenburg 2004-06-05 21:24:19 UTC

Commited.

I'll file another bug report for the tab-arrow when I clarify when it happens.