Bug 81304

Summary: kdirselectdialog.h missing #include <qpopupmenu.h>
Product: [Frameworks and Libraries] kio Reporter: Unknown <null>
Component: kfileAssignee: Carsten Pfeiffer <pfeiffer>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:

Description Unknown 2004-05-11 09:41:13 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.2.3 
OS:                Linux

Programs that include kdirselectdialog.h will not compile unless qpopupmenu.h is explicitly included (eg kdirselectdialog.cpp).

kdirselectdialog.h requires qpopupmenu.h since QPopupMenu is referenced in line 112.

105:private:
106:    void readConfig( KConfig *config, const QString& group );
107:    void saveConfig( KConfig *config, const QString& group );
108:    void openNextDir( KFileTreeViewItem *parent );
109:    KFileTreeBranch * createBranch( const KURL& url );
110:
111:    KFileTreeView *m_treeView;
112:    QPopupMenu *m_contextMenu;
113:    KToggleAction *m_showHiddenFolders;
114:    bool m_localOnly;

Would it not make more sense to #include <qpopupmenu.h> in this header file? Otherwise programs such as kdebingings/kdejava/koala/kdejava/KDirSelectDialog.cpp MUST include qpopupmenu or else it won't compile.
Comment 1 Christian Loose 2004-05-11 10:59:21 UTC
Fixed in CVS (rev. 1.11 of kdirselectdialog.h).