Bug 76427

Summary: kgpg editor doesn't use KDE's default fixed width font. Breaks layout
Product: [Applications] kgpg Reporter: Gilles Schintgen <gschintgen>
Component: generalAssignee: bj
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:

Description Gilles Schintgen 2004-02-29 17:01:05 UTC
Version:            (using KDE KDE 3.2.0)
Installed from:    Gentoo Packages
OS:          Linux

kgpg's editor doesn't allow to chose the text font. This is quite an annoying bug for me, since I'm often handling plain text files with alignments which rely on using a monospaced font.
At least the editor could default to KDE's default fixed width font. After all, it's a plain text editor...
Comment 1 bj 2004-03-01 02:42:46 UTC
Thank you for your bug report.
The bug that you reported has been identified and has been fixed in the
latest development (CVS) version of KDE. The bug report will be closed.
Comment 2 Gilles Schintgen 2004-12-24 15:31:13 UTC
Please don't hit me for reopening ;-)
I'm very happy that the font is now configurable, _but_ the default is still _not_ fixed width (at least with KDE 3.3.2). This is contrary to the other KDE editors (kedit, kwrite, kate) which all default to fixed width.
IMHO fixed width has only advantages when compared to variable width fonts, so I'd be glad to see this reflected in kgpg's default settings, which, as I suppose, should be the best choice for the majority of users.

Happy Holidays!
Comment 3 bj 2005-02-02 22:23:38 UTC
CVS commit by mardelle: 

store font in kcfg file, default to fixed width.
CCMAIL: 76427-done@bugs.kde.org


  M +7 -0      kgpg.kcfg   1.17
  M +1 -4      kgpgeditor.cpp   1.55
  M +2 -4      kgpgoptions.cpp   1.66


--- kdeutils/kgpg/kgpgeditor.cpp  #1.54:1.55
@@ -65,9 +65,6 @@ KgpgApp::KgpgApp(QWidget *parent, const 
         initView();
 
-        KSimpleConfig *ks=new KSimpleConfig ("kgpgrc");
-        ks->setGroup("Editor");
-        slotSetFont(ks->readFontEntry("Editor_Font"));
+        slotSetFont(KGpgSettings::font());
         setupGUI(( ToolBar | Keys | StatusBar | Save | Create ), "kgpg.rc");
-        delete ks;
 
 }

--- kdeutils/kgpg/kgpg.kcfg  #1.16:1.17
@@ -174,4 +174,11 @@
     </entry>
     </group>
+
+  <group name="Text Font">
+    <entry name="Font" type="Font" key="KEditFont">
+      <label>Font</label>
+      <default code="true">KGlobalSettings::fixedFont()</default>
+    </entry>
+  </group>
     
 <group name="Key Servers">

--- kdeutils/kgpg/kgpgoptions.cpp  #1.65:1.66
@@ -65,6 +65,4 @@ kgpgOptions::kgpgOptions(QWidget *parent
 {
         ks=new KSimpleConfig ("kgpgrc");
-        ks->setGroup("Editor");
-        startFont=ks->readFontEntry("Editor_Font");
 
         defaultServerList="hkp://wwwkeys.eu.pgp.net ";
@@ -92,7 +90,7 @@ kdDebug(2100)<<"Adding pages"<<endl;
         page7=new MiscConf();
         QBoxLayout *fontLayout=new QBoxLayout(page3->tabWidget3->page(1),QBoxLayout::TopToBottom,10);
-        kfc=new KFontChooser(page3->tabWidget3->page(1),0L,false,QStringList(),false);
+        kfc=new KFontChooser(page3->tabWidget3->page(1),"kcfg_Font",false,QStringList(),false);
         fontLayout->addWidget(kfc);
-        kfc->setFont(startFont);
+
         page7->shredInfo->setText(i18n( "<qt><p>You must be aware that <b>shredding is not secure</b> on all file systems, and that parts of the file may have been saved in a temporary file or in the spooler of your printer if you previously opened it in an editor or tried to print it. Only works on files (not on folders).</p></qt>"));
         page7->groupShred->adjustSize();


Comment 4 Gilles Schintgen 2005-02-02 22:29:41 UTC
> store font in kcfg file, default to fixed width.
> CCMAIL: 76427-done bugs kde org
Thanks!