Bug 75491

Summary:	Encoding combobox in file dialog touches URL bar
Product:	[Frameworks and Libraries] kio	Reporter:	Rayiner Hashem <gtg990h>
Component:	kfile	Assignee:	Carsten Pfeiffer <pfeiffer>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Proposed patch

Description Rayiner Hashem 2004-02-18 06:54:33 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          GCC 3.3.3 
OS:          Linux

In file dialogs that use KEncodingFileDialog (such as kwrite), the encoding combobox touches the URL bar that comes before it. This is visually unappealing.

Comment 1 Rayiner Hashem 2004-02-18 06:56:38 UTC

Created attachment 4758 [details]
Proposed patch

Adding a seperator right before adding the encoding combo-box fixes the
problem.

Comment 2 Pascal Létourneau 2004-02-19 21:43:42 UTC

CVS commit by pletourn: 

Add a separator between the two combobox
Patch taken from the bug report, thanks
CCMAIL: 75491-done@bugs.kde.org


  M +1 -0      kencodingfiledialog.cpp   1.4


--- kdelibs/kio/kfile/kencodingfiledialog.cpp  #1.3:1.4
@@ -47,4 +47,5 @@ KEncodingFileDialog::KEncodingFileDialog
     
   KToolBar *tb = toolBar();
+  tb->insertSeparator();
   int index = tb->insertCombo(QStringList(), -1 /*id*/, false /*writable*/, 0 /*signal*/, 0 /*receiver*/, 0 /*slot*/ );
   d->encoding = tb->getCombo( tb->idAt( index ) );