Summary: | drawing glitches when active song (red) is under play menu in playlist | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Frederik Holljen <fh> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Frederik Holljen
2004-02-16 15:36:58 UTC
CVS commit by markey: Fixed ExpandButton drawing glitches (BR #75356), and made the animation faster. Introduces some new, funny redraw problems :) To be fixed.. CCMAIL: 75356@bugs.kde.org M +1 -1 browserwin.cpp 1.74 M +24 -43 expandbutton.cpp 1.15 M +7 -4 expandbutton.h 1.7 CVS commit by markey: ExpandButton fixes: * fix flicker at beginning of animation * code cleanup TODO: Weird flicker after the button has closed again, which is a repaint problem issued by hiding the widget we paint. I'm not sure why this happens. Qt seems to redraw some weird crap for a short moment, instead of the correct rectangle of the parent-widget. Let's hope this is not a Qt/X limitation. If it is, I'm fed up with these shenanigans and will remove the animation completely until we have a proper X-server. CCMAIL: 75356@bugs.kde.org M +74 -80 expandbutton.cpp 1.16 M +14 -16 expandbutton.h 1.8 CVS commit by mhowell: * To appease our loyal fan Grue_, a blank analyzer. Simply a QLabel that says "Click for Analyzers". This is actually not a hack due to my recent mods to the analyzer classes. The QLabel is accepted into the widget perfectly. No timers are activated for it or anything. * The interesting thing is to note just how little CPU our analyzers use, and just how much aRts uses decoding MP3s etc. * This isn't the solution that was agreed on, but I saw it was easy and did it. It'll do for now. CCMAIL: 75356@bugs.kde.org M +13 -7 analyzerfactory.cpp 1.14 --- kdeextragear-1/amarok/amarok/analyzers/analyzerfactory.cpp #1.13:1.14 @@ -38,8 +38,10 @@ #endif +#include <qlabel.h> +#include <klocale.h> + //separate from analyzerbase.cpp to save compile time -//sorry if this isn't to your liking.. -//const + QWidget *Analyzer::Factory::createAnalyzer( QWidget *parent ) { @@ -57,20 +59,24 @@ QWidget *Analyzer::Factory::createAnalyz analyzer = new TurbineAnalyzer( parent ); break; -#ifdef HAVE_QGLWIDGET case 4: - analyzer = new GLAnalyzer( parent ); + analyzer = new QLabel( i18n( "Click for Analyzers" ), parent ); //blank analzyer to satisfy Grue + static_cast<QLabel *>(analyzer)->setAlignment( Qt::AlignCenter ); break; +#ifdef HAVE_QGLWIDGET case 5: + analyzer = new GLAnalyzer( parent ); + break; + case 6: analyzer = new GLAnalyzer2( parent ); break; #endif #ifndef AMAROK_RELEASE - case 6: + case 7: analyzer = new XmasAnalyzer( parent ); break; - case 7: + case 8: analyzer = new BlockAnalyzer( parent ); break; - case 8: + case 9: analyzer = new BarAnalyzer2( parent ); break; *** Bug has been marked as fixed ***. |