Summary: | Dangerous usability issue: when Juk asks to delete files, "Yes" button is default | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Thibaut Cousin <kde> |
Component: | general | Assignee: | Scott Wheeler <wheeler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Thibaut Cousin
2004-02-12 13:32:24 UTC
Well, the menu option is "Remove From Disk" and the prompt says "Do you really want to remove these files from your disk?" I'm not really sure how to make that more clear. This is actually currently a problem with the default KDE warning dialog -- it defaults to yes. I'm not sure how many apps depend on that though so I'll probably have to write a new dialog... Well, the most important thing is the default choice in the dialog box. I'm very surprised that this problem is KDE-wide... Is it a bug? As for the other option, it was just an added bonus, since Juk is able to delete an awful lot of file by mistake. But it's less important, as you pointed out. Thanks for your quick answer. Scott, you are using KMessageBox::questionYesNoList() method to show the question and that seems to be the problem. Change it to KMessageBox::warningYesNoList() and the default will be the "No" button. No need for a for a new dialog... Christian On Friday 13 February 2004 10:08, Christian Loose wrote:
> Scott, you are using KMessageBox::questionYesNoList() method to show the
> question and that seems to be the problem. Change it to
> KMessageBox::warningYesNoList() and the default will be the "No" button.
Ah, that's relatively new in kdelibs -- also I had in mind the fact that
warningYesNoCancelList() defaults to "yes".
CVS commit by wheeler: Use a warning dialog instead of a question dialog. CCMAIL:75063-done@bugs.kde.org M +1 -1 playlist.cpp 1.170 --- kdemultimedia/juk/playlist.cpp #1.169:1.170 @@ -600,5 +600,5 @@ void Playlist::removeFromDisk(const Play message = i18n("Do you really want to delete these %1 items from your disk?").arg(QString::number(files.count())); - if(KMessageBox::questionYesNoList(this, message, files) == KMessageBox::Yes) { + if(KMessageBox::warningYesNoList(this, message, files) == KMessageBox::Yes) { for(PlaylistItemList::ConstIterator it = items.begin(); it != items.end(); ++it) { if(QFile::remove((*it)->filePath())) { |