| Summary: | Enabling WinAmp skin crashes Arts | ||
|---|---|---|---|
| Product: | noatun | Reporter: | John T. Ellis <john.ellis> |
| Component: | winskin | Assignee: | Charles Samuels <charles> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | billing, gentoopower, js, zander |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Backtrace after Artsd crash
Patch for the Noatun Winskin freeze |
||
|
Description
John T. Ellis
2004-02-09 02:55:23 UTC
Created attachment 4589 [details]
Backtrace after Artsd crash
Backtrace after switching to a WinAmp skin and hitting "Apply."
Don't try switching directly betwen kjofol and winamp, for some reason artsd REALLY dislikes two plugins using FFT code. This problem suddenly appeared somewhere between KDE 3.1 and KDE 3.2 on this machine but as it hard locks the system I cannot debug it. OTOH on my KDE 3.1 install (laptop) the same happens but the system does not hard lock (noatun and artsd crash, no usable backtrace either). Actually, I've been skipping K-Jofol skins completely since reporting bug 74263. The crash comes from switching from Excellent or any other skin to WinAmp. Or, for that fact, just setting it manually in the rc file and starting it without the plugin GUI. My problem is even worse, as soon as I press apply after selecting winamp skin, my maschine is completely frozen, it won't react to any keystrokes anymore, the only thing I can do is to press the powerbutton. It's 100% reproducable, from standard noatun-> Settings-->Configure Noatun-->Plugins--> mark WinAmp Interface, press Apply and my box is down. I haven't seen such a crash in years folks, I can't believe this. *** Bug 78884 has been marked as a duplicate of this bug. *** Created attachment 7350 [details]
Patch for the Noatun Winskin freeze
After a couple of hours and a lot of reboots I have finally found and fixed this bug (see enclosed patch). Can this fix be included in the next version of KDE? CVS commit by charles: patch by Johan Billing <billing@df.lth.se> I believe this fixes all sorts of crashings with regards to the mysterious winskin crashes. A big round of appreciation goes to Johan, as this bug has been around for ages and nobody has been able to find it. However, it seems like it's a real stupid one and valgrind should have been able to catch it. Thanks Johan! (backport soon) CCMAIL:74666-done@bugs.kde.org M +1 -0 visQueue.cpp 1.4 --- kdemultimedia/noatun/modules/winskin/vis/visQueue.cpp #1.3:1.4 @@ -18,4 +18,5 @@ VISQueue::VISQueue(int elements) { this->elements=elements; int i; + visArrayQueue.reserve(elements); for(i=0;i<elements;i++) { visArrayQueue[i]=new std::vector<float>; |