Summary: | khtml::CachedImage::ref crashes recently introduced | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Stephan Binner <binner> |
Component: | khtml | Assignee: | Dirk Mueller <mueller> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | d.siska, gritzko, rzei |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Stephan Binner
2004-01-16 11:15:31 UTC
Don't let understate this. Another site: Choosing category on art.gnome.org I can't make it crash on kde.openoffice.org (Dirk fixed one case afaik), but I load gnomedesktop.org, click on the guadec2004 link and then press back -> assertion Subject: kdelibs/khtml [POSSIBLY UNSAFE] CVS commit by mueller: CCMAIL: 72739-done@bugs.kde.org M +5 -0 ChangeLog 1.162 M +3 -15 rendering/render_image.cpp 1.127 [POSSIBLY UNSAFE: qDebug] --- kdelibs/khtml/ChangeLog #1.161:1.162 @@ -1,2 +1,7 @@ +2004-01-16 Dirk Mueller <mueller@kde.org> + + * rendering/render_image.cpp: remove some asserts that + noone needs anyway (#72739). + 2004-01-16 Stephan Kulow <coolo@kde.org> --- kdelibs/khtml/rendering/render_image.cpp #1.126:1.127 @@ -68,7 +68,4 @@ RenderImage::RenderImage(NodeImpl *_elem RenderImage::~RenderImage() { - assert( !image || image != oimage ); - assert( !image || !image->canDelete() ); - assert( !oimage || !oimage->canDelete() ); if(image) image->deref(this); if (oimage) oimage->deref( this ); @@ -105,4 +102,6 @@ void RenderImage::setPixmap( const QPixm } + qDebug( "RenderImage::setPixmap!!" ); + bool iwchanged = false; @@ -377,12 +376,5 @@ void RenderImage::notifyFinished(CachedO } - assert( image ); - assert( !image->canDelete() ); - if ( image == finishedObj && oimage ) { - assert( image != oimage ); - assert( oimage != finishedObj ); - assert( !oimage->canDelete() ); - oimage->deref( this ); oimage = 0; @@ -416,5 +408,4 @@ void RenderImage::updateImage(CachedImag { CachedImage* tempimage = oimage; - assert( !tempimage || !tempimage->canDelete() ); oimage = image; image = new_image; @@ -425,7 +416,4 @@ void RenderImage::updateImage(CachedImag tempimage->deref(this); - assert( image ); - assert( !image->canDelete() ); - assert( !oimage || !oimage->canDelete() ); berrorPic = image->isErrorImage(); } *** Bug 72952 has been marked as a duplicate of this bug. *** *** Bug 73156 has been marked as a duplicate of this bug. *** |