Summary: | Multiple select takes actions on files that are filtered out of the current view | ||
---|---|---|---|
Product: | [Applications] cervisia | Reporter: | Dan Christensen <daniel_l_christensen> |
Component: | general | Assignee: | Christian Loose <christian.loose> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 2.1 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Dan Christensen
2004-01-12 23:43:44 UTC
I've dug into this a little bit and it looks like it may be a QListView problem. Apparently when you click an item, hold down the shift key and then select another item in the list it marks all the items between those two items as selected, regardless of whether or not they are visible. It would be easy enough to work around the problem by adding some code in UpdateView::multipleSelection and UpdateView::fileSelection to check whether or not the list item was visible before adding it to the string list. However, this is a problem that should probably be dealt with at the QT level. Hi Dan, thank you for your report. You're right, there is missing an extra test if the item is visible. I'll ask the trolls if they consider this a bug. This bug could be dangerous if you choose "Remove from Repository". André Subject: kdesdk/cervisia CVS commit by woebbe: Fix BR 72519 (file view): Don't select hidden files when you select a range of files with Shift key. This prevents you from evil accidents (i.e. "Remove from Repository"). CCMAIL: 72519-done@bugs.kde.org M +7 -1 ChangeLog 1.106 M +3 -2 updateview.cpp 1.54 --- kdesdk/cervisia/ChangeLog #1.105:1.106 @@ -1,2 +1,9 @@ +2004-01-16 Andr |