Summary: | KNode considers "280" response an error | ||
---|---|---|---|
Product: | knode | Reporter: | Gunnar Strand <Gunnar.Strand> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 0.7.2 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Solaris | ||
Latest Commit: | Version Fixed In: |
Description
Gunnar Strand
2004-01-12 19:12:31 UTC
Additional: Unless it is clear from the report: it is not possible to subscribe to groups due to this problem. Subject: Re: [Knode-devel] New: KNode considers "280" response an error Would it be possible for me to try this server of yours? Or it requires authentication? I just wanted to run a few tests. Unfortunately it is at work behind a firewall. But if you are fluent in perl then you can install the package yourself: NNML::Server. It can also be found at search.cpan.org. I made a workaround to this problem by modifying the perl code so that 200 is returned to the client instead. Subject: kdepim/knode CVS commit by maragato: Don't just test for 200 and 201 as command results. Read all 2xx results as ok (RFC977) CCMAIL: 72500-done@bugs.kde.org M +4 -4 knnntpclient.cpp 1.55 --- kdepim/knode/knnntpclient.cpp #1.54:1.55 @@ -561,6 +561,6 @@ bool KNNntpClient::openConnection() return false; - if ((rep!=200)&&(rep!=201)) { // 200 server ready - posting allowed - handleErrors(); // 201 server ready - no posting allowed + if ( ( rep < 200 ) || ( rep > 299 ) ) { // RFC977: 2xx - Command ok + handleErrors(); return false; } @@ -576,6 +576,6 @@ bool KNNntpClient::openConnection() #endif } else - if ((rep!=200)&&(rep!=201)) { // 200 Hello, you can post - handleErrors(); // 201 Hello, you can't post + if ( ( rep < 200 ) || ( rep > 299 ) ) { // RFC977: 2xx - Command ok + handleErrors(); return false; } |