Bug 72159

Summary:	[test case] colors specified in tag selector are forgotten when another class selector exists (regression)
Product:	[Applications] konqueror	Reporter:	John O'Donnell <johnod>
Component:	khtml	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	test case

Description John O'Donnell 2004-01-08 16:24:06 UTC

Version:            (using KDE KDE 3.1.94)
Installed from:    Slackware Packages
OS:          Linux

http://bar.homelinux.com/index2.shtml

All the links are either green or dark green.  In IE/Opera/Mozilla it appears the proper orange color.

The CSS file specifies:

A:LINK
  { COLOR: #ff9900; }
A:ACTIVE
  { COLOR: LIME; }
A:VISITED
  { COLOR: #ff9900; }

But this is what I see..
http://bar.homelinux.com/konq.gif

Comment 1 Stephan Kulow 2004-01-11 15:46:29 UTC

Created attachment 4097 [details]
test case

The real test case, you quoted not the relevant parts above

Comment 2 Stephan Kulow 2004-01-11 15:47:39 UTC

I'd say this breaks quite some colors

Comment 3 Dirk Mueller 2004-01-11 17:23:32 UTC

Subject: kdelibs/khtml

CVS commit by mueller: 

make parsing of pseudo types case insensitive
CCMAIL: 72159-done@bugs.kde.org


  M +4 -0      ChangeLog   1.149
  M +3 -2      css/css_base.cpp   1.12


--- kdelibs/khtml/ChangeLog  #1.148:1.149
@@ -1,2 +1,6 @@
+2004-01-11  Dirk Mueller  <mueller@kde.org>
+
+        * css/css_base.cpp (extractPseudoType): make it case-insensitive (#72159).
+
 2004-01-11  Germain Garand  <germain@ebooksfrance.org>
 

--- kdelibs/khtml/css/css_base.cpp  #1.11:1.12
@@ -165,4 +165,5 @@ void CSSSelector::extractPseudoType() co
     _pseudoType = PseudoOther;
     if (!value.isEmpty()) {
+        value = value.lower();
         switch (value[0]) {
             case 'a':
@@ -306,5 +307,5 @@ DOMString CSSSelector::selectorText() co
                 break;
             case CSSSelector::Set:
-                str += " "; /// ## correct?
+                str += " "; // ## correct?
                        break;
             case CSSSelector::List: