Bug 70661

Summary: KMultiTabBarTab constructor does not initialize m_showActiveTabText.
Product: [Frameworks and Libraries] kdelibs Reporter: Bruce R'. Miller <brm>
Component: generalAssignee: Stephan Kulow <coolo>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Initialize m_showActiveTabText

Description Bruce R'. Miller 2003-12-17 10:01:40 UTC 
Version:            (using KDE KDE 3.1.94)
Installed from:    Compiled From Sources
Compiler:          g++ (GCC) 3.2.2 20030222 (Red Hat Linux 3.2.2-5) 
OS:          Linux

This generates a lot of spurious messages when I use Valgrind to debug a kdevelop crash.
Comment 1 Christian Loose 2004-01-03 03:29:19 UTC 
Created attachment 3944 [details]
Initialize m_showActiveTabText

I choosed false as initial value since KMultiTabBarInternal sets its
m_showActiveTabTexts member variable to false also.
Comment 2 Stephan Kulow 2004-01-16 14:03:33 UTC 
Subject: kdelibs/kutils

CVS commit by coolo: 

uninitialized variables are really, really bad ;(
CCMAIL: 70661-done@bugs.kde.org


  M +2 -1      kmultitabbar.cpp   1.51


--- kdelibs/kutils/kmultitabbar.cpp  #1.50:1.51
@@ -293,5 +293,6 @@ KMultiTabBarTab::KMultiTabBarTab(const Q
                 int id,QWidget *parent,KMultiTabBar::KMultiTabBarPosition pos,
                 KMultiTabBar::KMultiTabBarStyle style)
-        :KMultiTabBarButton(text,0,id,parent,pos,style)
+        :KMultiTabBarButton(text,0,id,parent,pos,style),
+        m_showActiveTabText(false)
 {
         d=new KMultiTabBarTabPrivate();