Summary: | konqueror: sizing error in framesets - off by one pixel | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Christian Boltz <kde-bugs> |
Component: | khtml renderer | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | testcase showing the off-by-one problem |
Description
Christian Boltz
2003-11-26 15:31:11 UTC
The problem still appears in KDE 3.2.2 (on SuSE 9.1) KDE 3.3.0 RC shows the same behaviour. "Unknown host http://www.wein-vin-vinum.net/home.php" Though this is most probably still valid. Maksim, if you ever happen to read this, what's your sentiment about the frame patch that was recently contributed to WebCore? My sentiment on that is this: I know it should fix bug #60113 (I actually sort of directed the author of the patch to the issue by showing that report), but I basically do not know enough to evaluate it, and don't have the time to brute-force test. I guess bug #101753 is related, too. P.S.: I read kde-bugs-dist, so I see virtually everything konq-related.. OK. So that's a nice fix but can be postponed a bit, AFAICS ... mostly a matter of finding the time to delve into the algorithm for some hours ;( Sorry that the page showing this bug is not reachable. I'll append a testcase.war file with an example (actually, it's from my local copy of the page, but reduced to the base components). BTW: I can reproduce the problem with KDE 3.4.2 on SUSE Linux 10.0 Created attachment 13212 [details]
testcase showing the off-by-one problem
Still reproduceable in KDE 3.5 SVN commit 518068 by ggarand: apply nice frame calculation enhancements patch by Niels Leenheer <niels.leenheer@gmail.com> cf. WC/3587 also, be extra careful not to apply complex masks to frames in KHTMLView::drawContents. BUG: 60113, 69074, 101753 M +8 -5 khtmlview.cpp M +1 -2 rendering/render_form.cpp M +141 -27 rendering/render_frames.cpp |