Bug 67577

Summary: kwin doesn't display maximize buttons for Tk apps
Product: [Plasma] kwin Reporter: stephen
Component: generalAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: hail, yuzyk
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:

Description stephen 2003-11-08 14:03:03 UTC
Version:            (using KDE KDE 3.1.93)
Installed from:    Gentoo Packages
Compiler:          gcc-3.3.2-r2 -mcpu=athlon-xp -O3 -pipe
OS:          Linux

Apps like tkconch and leo which use the Tk toolkit don't have a maximize button present.

When I start up kde3.1, the maximize button is there.
Comment 1 Lubos Lunak 2003-11-11 18:17:01 UTC
Please attach output from 'xprop' for the windows.
Comment 2 stephen 2003-11-12 00:36:39 UTC
Typing "xprop" on a konsole session and selecting the leo window makes this output:

 $ xprop
_NET_WM_ICON_GEOMETRY(CARDINAL) = 798, 1026, 150, 21
_NET_WM_STATE(ATOM) =
WM_STATE(WM_STATE):
                window state: Normal
                icon window: 0x0
_NET_AM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE
_KDE_NET_WM_FRAME_STRUT(CARDINAL) = 3, 4, 29, 8
_NET_WM_DESKTOP(CARDINAL) = 0
WM_NORMAL_HINTS(WM_SIZE_HINTS):
                user specified location: 0, 0
                program specified minimum size: 30 by 10
                program specified maximum size: 1265 by 994
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
WM_HINTS(WM_HINTS):
                Client accepts input or input focus: True
                Initial state is Normal State.
WM_ICON_NAME(STRING) =
WM_CLASS(STRING) = "139007260", "Toplevel"
WM_NAME(STRING) = "untitled"
_KDE_NET_WM_USER_CREATION_TIME(CARDINAL) = 520615570
Comment 3 Lubos Lunak 2003-11-12 09:53:41 UTC
As you can see in the output, the window specifies maximum size. Windows with maximum size limited cannot be maximized.
Comment 4 stephen 2003-11-12 14:08:58 UTC
Interesting. I can see that the maximum horizontal size is less than the program specified maximum size. 

The maximize button is present with kde-3.1.4. Is this something just getting enforced? 

It must be some kind of Tk default that people never change, because all of the tk apps seem to have the same max size.
Comment 5 Lubos Lunak 2003-11-13 12:41:15 UTC
KWin in 3.1.4 didn't disable the button with maximum size specified, yes. Only the new KWin does. E.g. even though the specified maximum size may be larger than screen size, the screen size may change (xrandr), and after that, it really won't be possible to maximize the window without disobeying the maximum size. Tk should not do that.
Comment 6 stephen 2003-11-13 13:59:36 UTC
Thanks for the explanation. I agree.

Stephen
Comment 7 Joe English 2004-03-13 00:20:24 UTC
Yep, this is a Tk bug.  Looking into it:

http://sourceforge.net/tracker/index.php?func=detail&aid=915350&group_id=12997&atid=112997

--JE
Comment 8 Joe English 2004-04-04 22:30:36 UTC
Now fixed in the CVS HEAD of Tk.  The patch at SourceForge can also be applied to Tk 8.4.5 / 8.4.6.
Comment 9 Lubos Lunak 2005-11-14 16:27:04 UTC
*** Bug 116027 has been marked as a duplicate of this bug. ***
Comment 10 Lubos Lunak 2006-01-19 09:41:34 UTC
*** Bug 120353 has been marked as a duplicate of this bug. ***