Summary: | KHotKeys doesn't recognize command parameters | ||
---|---|---|---|
Product: | [Plasma] khotkeys | Reporter: | Mikko Ikola <ikola> |
Component: | general | Assignee: | Lubos Lunak <l.lunak> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Mikko Ikola
2003-09-28 15:39:55 UTC
And it doesn't work when using from kmenuedit, either.. Subject: kdebase/khotkeys/shared [POSSIBLY UNSAFE] CVS commit by lunakl: Fix #65085. CCMAIL: 65085-done@bugs.kde.org M +11 -6 actions.cpp 1.4 [POSSIBLY UNSAFE: KRun::runCommand] --- kdebase/khotkeys/shared/actions.cpp #1.3:1.4 @@ -117,12 +117,16 @@ void Command_url_action::execute() if( command_url().isEmpty()) return; - int space_pos = command_url().find( ' ' ); KURIFilterData uri; QString cmd = command_url(); - if( command_url()[ 0 ] != '\'' && command_url()[ 0 ] != '"' && space_pos > -1 - && command_url()[ space_pos - 1 ] != '\\' ) - cmd = command_url().left( space_pos ); // get first 'word' +// int space_pos = command_url().find( ' ' ); +// if( command_url()[ 0 ] != '\'' && command_url()[ 0 ] != '"' && space_pos > -1 +// && command_url()[ space_pos - 1 ] != '\\' ) +// cmd = command_url().left( space_pos ); // get first 'word' uri.setData( cmd ); KURIFilter::self()->filterURI( uri ); + if( uri.uri().isLocalFile() && !uri.uri().hasRef() ) + cmd = uri.uri().path(); + else + cmd = uri.uri().url(); switch( uri.uriType()) { @@ -154,6 +158,7 @@ void Command_url_action::execute() if (!kapp->authorize("shell_access")) return; - if( !KRun::runCommand( cmd, - cmd + ( uri.hasArgsAndOptions() ? uri.argsAndOptions() : "" ), uri.iconName())) + if( !KRun::runCommand( + cmd + ( uri.hasArgsAndOptions() ? uri.argsAndOptions() : "" ), + cmd, uri.iconName())) // CHECKME ? ; I am using KDE 3.5.1 on Ubuntu Dapper and it doesn't work. It doesn't understand passed parameters when defining a command in khotkeys. How can I reopen the bug? Works fine for me here. Can you attach your khotkeysrc with only the one action that doesn't work? |