Bug 64985

Summary:	default custom colours appear to change PGP signature status
Product:	[Applications] kmail	Reporter:	Will Stephenson <wstephenson>
Component:	GUI	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	one line fix to change initial custom colour values to match profile colours

Description Will Stephenson 2003-09-26 11:39:11 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

In KMail you have the option of using default colours or a custom colour scheme.  
Unfortunately, if you switch to a custom colour scheme, hardcoded initial values are used for the custom colours, that are not quite the same as the default colour scheme, which comes (I think) from the profiles .desktop entries.   
This causes the colour for PGPOkKeyBad (untrusted key) to change from FFFF40 yellow to A0FF40 grass green, which is similar to the FFFF40 green used for PGPOkKeyGood (trusted key).  This could lead to all sorts of mistakes.

Patch to follow.

Comment 1 Will Stephenson 2003-09-26 11:41:15 UTC

Created attachment 2586 [details]
one line fix to change initial custom colour values to match profile colours

Comment 2 Stephan Kulow 2003-09-27 21:46:21 UTC

Subject: kdepim/kmail

CVS commit by coolo: 

light yellow is light yellow
CCMAIL: 64985-close@bugs.kde.org


  M +1 -1      configuredialog.cpp   1.390


--- kdepim/kmail/configuredialog.cpp  #1.389:1.390
@@ -1847,5 +1847,5 @@ void AppearancePage::ColorsTab::setup() 
     QColor( 0x00, 0x80, 0xFF ), // light blue // pgp encrypted
     QColor( 0x40, 0xFF, 0x40 ), // light green // pgp ok, trusted key
-    QColor( 0xA0, 0xFF, 0x40 ), // light yellow // pgp ok, untrusted key
+    QColor( 0xFF, 0xFF, 0x40 ), // light yellow // pgp ok, untrusted key
     QColor( 0xFF, 0xFF, 0x40 ), // light yellow // pgp unchk
     Qt::red, // pgp bad