Summary: | File Already Exists Dialog Flies Off the Screen Due To Long File Names! (makes KDE look very unpolished) | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kio | Reporter: | Alex Radu <AlexRadu01> |
Component: | uiserver | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED UNMAINTAINED | ||
Severity: | normal | CC: | andresbajotierra |
Priority: | NOR | ||
Version: | 3.1.3 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
here's what I mean
KDE 3.5: 'File already exists' window too large for certain files |
Description
Alex Radu
2003-08-15 23:26:16 UTC
Created attachment 2247 [details]
here's what I mean
And the weird part is that the dialog is twice as wide as you actually get to
see on screen.
Subject: Re: New: File Already Exists Dialog Flies Off the Screen Due To Long File Names! (makes KDE look very unpolished)
Am Friday 15 August 2003 23:26 schrieb Alex Radu:
> This makes KDE look unpolished and poorly designed so I really hope this si
> fixed before 3.2.
Hmm, to me it makes java.com look silly and stupid me, but oppinions on
that may differ.
Greetings, Stephan
Well, that's a long link, makes nothing look stupid but KDE. There are lots of servers using very long links, but the one you actually type is usually not long. Now, maybe it would be a little friendlier to the users if the links weren't so long, but as I already said many have such long links and the user shouldn't really care or be affected by this. KDE, imo should adapt to this by creating new rows, instead of expanding one row to the right until it can display the long link. Subject: kdelibs/kio/kio CVS commit by adawit: - Use a squeezed text label to stop the rename dialog box from getting ridiculously large. Fixes BR# 62736. CCMAIL: 62736-done@bugs.kde.org M +21 -17 renamedlg.cpp 1.67 --- kdelibs/kio/kio/renamedlg.cpp #1.66:1.67 @@ -47,4 +47,5 @@ #include <kstdguiitem.h> #include <kguiitem.h> +#include <ksqueezedtextlabel.h> using namespace KIO; @@ -229,5 +230,6 @@ RenameDlg::RenameDlg(QWidget *parent, co else sentence1 = i18n("A newer item named '%1' already exists."); - QLabel * lb1 = new QLabel( sentence1.arg(KStringHandler::csqueeze(d->dest,100)), this ); + + QLabel * lb1 = new KSqueezedTextLabel( sentence1.arg(d->dest), this ); gridLayout->addMultiCellWidget( lb1, 0, 0, 0, 1 ); // takes the complete first line @@ -264,5 +266,5 @@ RenameDlg::RenameDlg(QWidget *parent, co gridLayout->addRowSpacing( 4, 20 ); - QLabel * lb2 = new QLabel( i18n("The source file is '%1'").arg(d->src), this ); + QLabel * lb2 = new KSqueezedTextLabel( i18n("The source file is '%1'").arg(d->src), this ); gridLayout->addMultiCellWidget( lb2, 5, 5, 0, 1 ); // takes the complete first line @@ -303,11 +305,13 @@ RenameDlg::RenameDlg(QWidget *parent, co QString sentence1; if (mtimeDest < mtimeSrc) - sentence1 = i18n("An older item than '%1' already exists.\n").arg(d->src); + sentence1 = i18n("An older item than '%1' already exists.\n"); else if (mtimeDest == mtimeSrc) - sentence1 = i18n("A similar file named '%1' already exists.").arg(d->src); + sentence1 = i18n("A similar file named '%1' already exists.\n"); else - sentence1 = i18n("A newer item than '%1' already exists.\n").arg(d->src); + sentence1 = i18n("A newer item than '%1' already exists.\n"); - QLabel *lb = new QLabel( sentence1 + i18n("Do you want to use another file name?"), this ); + sentence1 += i18n("Do you want to use another file name ?"); + + QLabel *lb = new KSqueezedTextLabel ( sentence1.arg(d->src), this ); d->m_pLayout->addWidget(lb); } Thank you fixing it! this was really annoying and unprofessional. I request that this bug be reopened. I'm seeing this problem in KDE 3.5. If I rename a file with a long name in Konqueror, the File Already Exists dialog is too long and goes off the screen. Spaces in file names appear as '%20', and the dialog looks like the one in the attached screenshot. The buttons are off the right side of the screen and inaccessible. Okay, it appears that this only happens for certain types of files--in this case, an MP3 file. Created attachment 14138 [details]
KDE 3.5: 'File already exists' window too large for certain files
What's the right category for kdeaddons/renamedlgplugins? Here using: Qt: 4.5.1 (qt-copy 960517) KDE: 4.2.71 (KDE 4.2.71 (KDE 4.3 >= 20090428)) kdelibs svn rev. 963904 / kdebase svn rev. 963904 on ArchLinux i686 - Kernel 2.6.29.1 The konqueror web-to-hd file already exists dialog is fixed (bug 51507) The copy dialog comparing MP3 also uses KSqueezedTextLabel, so long URLs are chopped and an ellipsis is included in the middle ("..."). The dialog is freely resizable. KDE 3 is no longer maintained. Additionally, the uiserver and KIO dialogs in general are substantially different in KDE 4 than the ones found in KDE 3. As such this bug is deemed no longer applicable. Feel free to reopen this ticket if you feel that is not the correct assessment and the bug is still applicable to the KDE 4.x branch. |