Bug 61820

Summary: switching coordinate-system doesn't affect "set focus manually"
Product: [Applications] kstars Reporter: ben <akula>
Component: generalAssignee: kstars
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In:

Description ben 2003-07-29 21:38:20 UTC
Version:           3.1.2 (using KDE KDE 3.1.2)
Installed from:    Debian testing/unstable Packages
Compiler:          3.3-2 
OS:          Linux

When i change the coordinate-system from equatorial to horizontal, the utility to set the focus manually is still in equatorial mode.

I can't enter the Azimut and height of an object, it still wants RA/Dec

greez ben
Comment 1 kstars 2003-07-29 23:20:12 UTC
Subject: kdeedu/kstars/kstars [POSSIBLY UNSAFE]

CVS commit by harris: 

Added the ability to specify Az/Alt coordinates with the FocusDialog.  The 
GUI elements were already in CVS, but the code to actually do it was still
missing.  I also changed the FocusDialog edit boxes from KLineEdits to
dmsBoxes, which allowed me to get rid of all the validation code in 
focusdialog.cpp (since dmsBox validates angle values internally).  
Speaking of which, I also made some improvements to the validation code in 
dmsBox::createDms(); it should be a bit more flexible and robust now.

This fixes bug #61820 (switching coordinate-system doesn't affect "set
focus manually").  To address the reporter's specific request, I also
added one more feature:  If the user is using the Azimuth/Altitude
coordinate system, then the FocusDialog comes up automatically on the
"Az/Alt" tab, whereas it used to always default to the "RA/Dec" tab.

However, from a usability standpoint, I am not sure if this is the
"correct" behavior.  Perhaps using Tabs here is a bad idea; we could
just show both pairs of dmsBoxes in a simple one-page dialog, and let the 
user fill in whichever pair they want.  Comments welcome.

CCMAIL: 61820-done@bugs.kde.org, kstars-devel@lists.sourceforge.net


  M +81 -78    dmsbox.cpp   1.19 [POSSIBLY UNSAFE: printf]
  M +36 -167   focusdialog.cpp   1.14
  M +10 -7     focusdialog.h   1.5
  M +106 -86   focusdialogdlg.ui   1.3
  M +6 -1      kstarsactions.cpp   1.61