Bug 61500

Subject: QUANTA_3_1_BRANCH: quanta

CVS commit by amantia: 

Don't insert the meta line with charset in the document when using QuickStart. This is a quick-fix, as in the CVS version we will have a new QuickStart generator.

CCMAIL: 61500-done@bugs.kde.org


  M +2 -0      ChangeLog   1.90.2.87
  M +1 -3      quanta/quantaview_slots.cpp   1.66.2.9


--- quanta/quanta/quantaview_slots.cpp  #1.66.2.8:1.66.2.9
@@ -250,5 +250,4 @@ void QuantaView::slotTagQuickStart(){
   if ( quickDlg->exec() )
    {
-    const QString chset = QTextCodec::codecForLocale()->mimeName();
 
     DTDStruct *dtd = write()->defaultDTD();
@@ -258,6 +257,5 @@ void QuantaView::slotTagQuickStart(){
                         tag += quickDlg->lineTitle->text();
     tag += QuantaCommon::tagCase("</title>\n")+space+
-           "  <meta http-equiv=\"Content-Type\" content=\"text/html; charset=" + chset + "\">\n"+
-           space+"  <meta name=\"GENERATOR\" content=\"Quanta Plus\">\n"+space+
+           "  <meta name=\"GENERATOR\" content=\"Quanta Plus\">\n"+space+
            QuantaCommon::tagCase("</head>\n")+space+QuantaCommon::tagCase("<body");
     if ( !QString(quickDlg->lineBGImage->text()).isEmpty())

--- quanta/ChangeLog  #1.90.2.86:1.90.2.87
@@ -4,4 +4,6 @@
   - bugfixes:
     - resolve symlinks before opening a file [#60860]
+    - don't insert the "<meta http-equiv="Content-Type" content="text/html; charset=..."
+      line when using the Quick Start dialog [#61500]
     - fix message window handling
     - fix script action error output handling

"2. this information is totally useless at all, as the Browser needs to know the charset to read the charset"

Well, you can't say that. It is not totally useless, as it was designed for the *server*.
The server must be able to read the line and use it for a header field in the response.
The line itself only contains of US-ASCII (7bit) characters, so he will always find it out.
Some servers are configured to always put a specific header charset field, without looking at this meta tag. But if the server does not, it will break W3C rules and the document will fail the validation test for example.
So this line is a help for the server, not for the browser (of course, as you wrote! The browser must know the charset before he can read the line where it is described).