| Summary: | kghostview scrolling with wheel is inconsistent | ||
|---|---|---|---|
| Product: | [Applications] kghostview | Reporter: | Albert Astals Cid <aacid> |
| Component: | general | Assignee: | Luís Pedro Coelho <luis> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
Subject: kdegraphics/kghostview CVS commit by aacid: - Set the focus back to the document when the user changes the zoom, that fixes bug #61619 - When scrolling down using wheel and reaching the bottom of the page go next page upper part instead of next page bottom part, this fixes bug #60603 CCMAIL:60603-done@bugs.kde.org CCMAIL:61619-done@bugs.kde.org M +8 -5 kgv_view.cpp 1.146 --- kdegraphics/kghostview/kgv_view.cpp #1.145:1.146 @@ -443,6 +443,8 @@ void KGVPart::slotReadDown() return; - if( !_pageView->readDown() ) - slotNextPage(); + if( !_pageView->readDown() ) { + if( _docManager->nextPage() ) + _pageView->scrollTop(); + } } @@ -845,4 +847,5 @@ void KGVPart::slotZoom( const QString& n miniWidget()->setDisplayOptions( options ); miniWidget()->redisplay(); + _mainWidget->setFocus(); } Has this patch been implemented? I'm running kghostview 0.20 and that behaviour, which is a big PitA, is still there without an option to toggle this off. i'm using kghostview with kde 3.4.2 and scrolling the page down with wheel goes to the next page top and scrolling the page up with the wheel goes to next page bottom, i think that's the exepected behaviour. |
Version: 0.20 (using KDE 3.1.9) Compiler: gcc version 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk) OS: Linux (i686) release 2.4.21-0.18mdk When you use the mouse wheel to scroll up the document and reach the upper edge of the page, it goes to nexts pages bottom side, this is fine. The inconsistent thing (to my mind) is that when scrolling down and reaching the bottom of a page, it goes to the next page but the bottom of it, instead of the top of it. That patch fixes the problem (i think) kgv_view.cpp @@ -442,8 +442,10 @@ if( !( document() && document()->isOpen() ) ) return; - if( !_pageView->readDown() ) - slotNextPage(); + if( !_pageView->readDown() ) { + if( _docManager->nextPage() ) + _pageView->scrollTop(); + } }