Bug 55573

Summary: Which diff command to use is not configurable
Product: [Applications] kompare Reporter: Russ LeBar <Russell.J.LeBar>
Component: generalAssignee: KDiff/Kompare bugs <bugs>
Status: CLOSED WORKSFORME    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Solaris   
Latest Commit: Version Fixed In:

Description Russ LeBar 2003-03-05 21:04:44 UTC
Version:            (using KDE KDE 3.1)
Installed from:    Compiled From Sources
Compiler:          gcc 3.2.1 
OS:          Solaris

In kompareprocess.cpp which diff command to use relies soley on the PATH. On Linux systems this is probably not a problem but e.g. on Solaris it is likely to use the wrong one.

Which diff to use should be determined at configure time. The configure script should detect which diff to use or error out of GNU diff is not on the system. There should also be a configure option (--diff=path_to_diff) to force it to the correct one.
Comment 1 Otto Bruggeman 2003-03-22 19:53:03 UTC
This will be implemented before 3.2 and if possible and not very intrusive for 
3.1.x, thanks for the report.
Comment 2 Otto Bruggeman 2003-04-21 00:31:54 UTC
Implemented in the make_it_cool branch, will put this back in head (therefore not 
sooner than KDE 3.2) as soon as i have the parser fully operational again. It wont 
be in 3.1.x because it is a new feature and i'm not allowed to add them in the 3.1.x 
branch anymore.