Summary: | Chat open (click on contact) crashes if protocol offline | ||
---|---|---|---|
Product: | [Applications] kopete | Reporter: | Boyd Faulkner <faulkner> |
Component: | libkopete | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Boyd Faulkner
2003-03-01 19:40:11 UTC
*** Bug 55392 has been marked as a duplicate of this bug. *** Subject: kdenonbeta/kopete/protocols/jabber CVS commit by gerken: Fixed crash for Jabber (does not fix other protocols in the CCed bug though) CCMAIL: 55385@bugs.kde.org M +8 -0 jabberprotocol.cpp 1.165 --- kdenonbeta/kopete/protocols/jabber/jabberprotocol.cpp #1.164:1.165 @@ -212,4 +212,12 @@ void JabberProtocol::init() connect(); + // create a contact instance for self + QString userId = KGlobal::config()->readEntry("UserID", ""); + QString server = KGlobal::config()->readEntry("Server", "jabber.org"); + myContact = new JabberContact( + QString("%1@%2").arg(userId, 1).arg(server, 2), + userId, QStringList(i18n("Unknown")), + this, 0L, QString::null); + } Interesting. I added the patch and now MSN will cause a crash, which it did not do before. I added a contact for ICQ and it did not crash but given what just happened, I wonder if there is an ordering problem. Well, I added an identity so I could connect and the crash went away again but MSN crashes until you add it. Subject: Re: [Kopete-devel] Chat open (click on contact) crashes if protocol offline
Boyd Faulkner wrote:
> Well, I added an identity so I could connect and the crash went
> away again but MSN crashes until you add it.
This has nothing to do with the previous bug.
Identities are still in work.
I am aware of this crash. I'm working on identities Api right now.
If you mean, the original report in this bug, I must wonder as the stack traces of the original report and the MSN crash with no identity set are the same. It looks like Till worked around it in Jabber, though. I suspect it will all clear up when the identities work is done. Thanks to you both, Boyd This is all because most protocols use myself() as argument to the message manager when it requires a KopeteContact for the originator of the messages. When being offline, this value can be uninitialized and myself() returns a null pointer or invalid pointer, which causes a crash later on when the widget tries display messages with it. I guess this problem will arise again when Kopete is being ported to identities. :) With the account system it is fixed now |