Bug 55139

Summary:	Closing Tabs by Keyboard Shortcut does not work
Product:	[Applications] konqueror	Reporter:	lenz
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	lofi, maksim
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:

Description lenz 2003-02-25 07:45:58 UTC

Version:           unknown (using KDE 3.1.0)
Installed from:    SuSE
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:          Linux (i686) release 2.4.20-4GB

I have defined "CTRL+W" as a shortcut to close the current
open tab. When I press this key combination, a small selection list pops up, giving me the choice to Quit or to close the current tab. However, selecting any entry with the keyboard (cursor up and down) and pressing enter or space does not work - I have to use the mouse to click on the selection. This makes the functionality of using a hotkey for this operation pointless.

Comment 1 Maksim Orlovich 2003-05-01 06:46:50 UTC

Can confirm; I've just sent a patch with the proposed fix to core-devel

Comment 2 Maksim Orlovich 2003-05-13 22:30:24 UTC

Subject: kdelibs/kdecore

CVS commit by orlovich: 


Let an entry in the accel conflict popup be activated with the keyboard, too, 
and not just selected. 

CCMAIL: 55139-done@bugs.kde.org


  M +4 -2      kshortcutmenu.cpp   1.2


--- kdelibs/kdecore/kshortcutmenu.cpp  #1.1:1.2
@@ -103,6 +103,8 @@ void KShortcutMenu::keyPressEvent( QKeyE
                         
                 if( iItem == -1 ) {
-                        // Let Up and Down keys navigate menu
-                        if( pEvent->key() == Qt::Key_Up || pEvent->key() == Qt::Key_Down )
+                        // Let Up and Down keys navigate menu,
+                        // And permit Enter, Return to select the item.
+                        if( pEvent->key() == Qt::Key_Up    || pEvent->key() == Qt::Key_Down ||
+                            pEvent->key() == Qt::Key_Enter || pEvent->key() == Qt::Key_Return )
                                 QPopupMenu::keyPressEvent( pEvent );
                         else

Comment 3 Maksim Orlovich 2003-06-05 01:03:17 UTC

*** Bug 55904 has been marked as a duplicate of this bug. ***