Bug 54646

Summary:	invokeBrowser / command line open in new tab instead of new window
Product:	[Applications] konqueror	Reporter:	Jason Keirstead <jason>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	dominik.stadler
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description Jason Keirstead 2003-02-14 19:17:48 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources

Currently,  kapp->invokeBrowser(), kfmclient, and konqueror <url> on the command line always open a new konqueror window, even if one already exists.

What I would like is for either this behaviour to respect the existing konq "Open new windows in tabs" setting, thus re-using existing windows, or add a new setting so we can select this.

It is very annoying to be able to have all your browsing sessions in one tabbed window, but to
have new windows pop up when you click links in kmail, knode, or any other non-konq application.

Comment 1 Javier Conti 2003-06-10 01:50:58 UTC

That is one of the most missed features for me when I begun using konqueror! 
 
I think that this could also be implemented as a command line switch for 
konqueror that could be then used to configure other apps or when invoking from 
cli.

Comment 2 Stephan Binner 2003-07-04 20:00:47 UTC

kfmclient, also used by kapp->invokeBrowser(), now respects the "Open links in 
new tab instead of in new window" option.

Comment 3 Jason Keirstead 2003-09-04 14:13:07 UTC

This bug still exists. Tried using both kfmclient openURL <url> and kfmclient
exec <url> with CVS HEAD as of Augest 18th. They still open in new windows, not
attaching to the already open Konqueror window.

Comment 4 Stephan Binner 2003-09-04 20:29:57 UTC

What bug? This feature still exists but uses a non-GUI config option added by a 
developer who prefers a boring life: 
http://lists.kde.org/?l=kde-cvs&m=105756410019435&w=2

Comment 5 Jason Keirstead 2003-09-04 20:39:10 UTC

For those too lazy to click: 
 
--- kdebase/konqueror/KonqMainWindowIface.cc  #1.18:1.19 
@@ -110,4 +110,7 @@ bool KonqMainWindowIface::processDynamic 
 bool KonqMainWindowIface::windowCanBeUsedForTab( int screen ) 
 { 
+    KGlobal::config()->setGroup("BonusFeatures"); 
+    if( !KGlobal::config()->readBoolEntry("MakeLifeInteresting", false) ) 
+        return false; // don't make the tab appear in a random location 
     if( qt_xscreen() != screen ) 
         return false; // this window shows on different screen 
 
I have two things to say about this: 
 
1. If this does fix this feature request ( Tabs appearing in a random 
location?? I don't see what this has to do with this feature request....), then 
it would have been nice to explain what hidden config option needs to be 
turned on to do so. 
 
2. Regardless, I don't see how it can be marked as "Closed" when there is 
not yet a GUI to enable it. How is anyone supposed to know it is there?

Comment 6 Stephan Binner 2003-09-04 22:39:02 UTC

It respected the "Open new windows in tabs" as you suggested when I closed the  
feature request. Later another developer found it funny to introduce this  
strangely named and placed additional setting without a GUI option and without 
reopening this report. Today me again, I added a GUI option.