Summary: | crash on randomplay when cddb query is running | ||
---|---|---|---|
Product: | kscd | Reporter: | Matthias Grimrath <maps4711> |
Component: | general | Assignee: | Aaron J. Seigo <aseigo> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | 1.3.3 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
alternate patch
kscd-3.1-2.diff |
Description
Matthias Grimrath
2003-02-02 18:57:55 UTC
Created attachment 877 [details]
alternate patch
does this patch fix the problem as well? if so, i'd prefer to apply this one...
Subject: Re: crash on randomplay when cddb query is running
> does this patch fix the problem as well? if so, i'd prefer to apply this
> one...
Yes, it does, and while I applied your patch I discovered another bug in the
'randomtrack()' function. If you insert no cd, activate looping, press
'random' and 'next title', the code
random_current = random_list.begin();
is executed. Since random_list is empty, the value of random_current is
undefined, so
int track = *random_current + 1;
could fail with a sigsegv. It didn't crash on my computer, still I think it
is better to not rely upon undefined iterators, so I wrote some code around
it.
Greets,
Matthias Grimrath
Created an attachment (id=879)
kscd-3.1-2.diff
*** Bug has been marked as fixed ***. |