Bug 52553

Summary:	[PATCH] Newsgroups header must not contain spaces (so let's remove them)
Product:	knode	Reporter:	Malte S. Stretz <mss>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Patch against kncomposer.cpp

Description Malte S. Stretz 2003-01-03 14:26:55 UTC

Version:            (using KDE KDE 3.0.99)
Installed from:    Compiled From Sources
Compiler:          gcc 3.2.1 
OS:          Linux

Hi,

it seems like the RFC does not allow spaces in the Newsgroups header. I tend to type a space after the comma if I insert the groups manually (eg. "de.test, linux.test" instead of "de.test,linux.test"). The news server will refuse those messages with something like '441 437 Whitespaces in "Newsgroups" header'. That's quite annoying, especially in combination with bug 44319.

To make mine (and probably others') life much easier, the attached patch removes all whitespaces from the Newsgroups header. Simple but efficient :o)

Cheers,
Malte

Comment 1 Malte S. Stretz 2003-01-03 14:28:02 UTC

Created attachment 690 [details]
Patch against kncomposer.cpp

P.S.: This is the first line I've ever written in C++ so I don't know if it's
the right place to remove the whitespaces and if it's 100% correct. Oh, the
patch is against the 3.1-rc5 sources.

Comment 2 Christian Gebauer 2003-01-06 02:09:18 UTC

your patch is correct and I applied it,  
thanks for the report