Bug 52043

Summary:	Clock applet doesn't show background image
Product:	[Plasma] kicker	Reporter:	trevor
Component:	kclockapplet	Assignee:	John Firebaugh <jfirebaugh>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ismail, maksim
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Screenshot demonstrating bug in Mosfet's Liquid style Fixes bug for the Plain and Fuzzy clock styles

Description trevor 2002-12-18 01:32:07 UTC

Version: (using KDE Devel)
Installed from: Compiled sources
Compiler: GCC 3.2
OS: Linux

Using the Panel settings, a background image can be specified for Kicker. This image appears on everything, even the date on the clock, but it doesn't appear on the clock's time. Another user, Gary Greene, produced a screen shot (attached) that shows the problem - but very faintly - when using Mosfet's Liquid style.

The problem is that the clock code sets a background color even when "Use custom colors" is disabled in the clock's settings. Also, the clock time widget doesn't call setBackgroundMode(QWidget::X11ParentRelative), but the date widget does, making the image appear in the date but not the time.

I created a patch to fix this problem (attached). It fixes the Plain and Fuzzy styles; however, I did not fix the LCD and Analog styles due to their more complex drawing routines.

After posting the patch on the kde-core-devel list (http://lists.kde.org/?t=103991785300002&r=1&w=2), Zack Rusin said: "I looked at your patch and I'm not sure if that's the way we want to do it. In Qt, backgroundMode of WindowOrigin works much better than X11ParentRelative for tiling across widgets. Mosfet was researching it
a little bit more and he found (to quote him from an email to me :) ) : Not only does it handle things like the digital clock's label correctly, it also works on all X servers. X11ParentRelative doesn't work well
with some S3 chipsets. I'm planning to switch some drawing code in Kicker in the next two weeks while adding translucency to it so please bare with me while I'm working on it. I think we can safely work on the clock once this done, unless someone considers drawing of the clock background a must fix for 3.1."

So currently the bug is in a state of limbo until Zack does the transparency work. This report is just to make sure the bug isn't forgotten.

Comment 1 trevor 2002-12-18 01:35:13 UTC

Created attachment 631 [details]
Screenshot demonstrating bug in Mosfet's Liquid style

It's difficult to see, but the stipple shown in the taskbar doesn't extend to
the clock. (The bug is easier to see with darker background images.)

Comment 2 trevor 2002-12-18 01:37:06 UTC

Created attachment 632 [details]
Fixes bug for the Plain and Fuzzy clock styles

Comment 3 Marek Olszewski 2003-05-20 23:14:54 UTC

This bug becomes even more noticable and annoying when you remove the clocks 
frame.

Comment 4 flstcboy 2003-05-31 12:13:06 UTC

thanks, 
yeah, this bug should not be forgotton... 
(about the S3-chipset-problem, maybe i got that too now, sometimes a window or the whole 
desktop is showing 'strange stripes', like a graphic bug, also it seems that the system freezes 
for a short time, but i think, that only relay to S3, so, that's no bug-report of me now ;) 
but, about the clock, i am waiting for that since kicker background is able to be set. 
c.u.

Comment 5 Aaron J. Seigo 2003-08-26 22:00:34 UTC

*** Bug has been marked as fixed ***.