Bug 50495

Summary:	configuring main toolbar makes the bookmark toolbar disappear until konqueror is restarted
Product:	[Frameworks and Libraries] kdelibs	Reporter:	johnelliottmartin
Component:	kedittoolbar	Assignee:	lypanov
Status:	RESOLVED FIXED
Severity:	normal	CC:	illogical1, ogoffart, pcman14
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Mandrake RPMs
OS:	Linux
Latest Commit:		Version Fixed In:

Description johnelliottmartin 2002-11-10 00:11:27 UTC

Version:            (using KDE KDE 3.0.9)
Installed from:    Mandrake RPMs

After customizing my main toolbar in konqueror, all my bookmark toolbar items disapear. The toolbar also becomes empty and is about half as big, here's a screenshot

http://web.pdx.edu/~elliott/toolbar_error.png

After restarting konqueror the bookmark toolbar is back to normal.

Here's one way to reproduce it.
- right click on the main toolbar in konqueror and choose "configure toolbars.."
- click on any item in the current items list (on the right) and move it up and then back down (so that the toolbar remains the way you had it, but so that the apply button is no longer greyed out)
- click apply.
you will now see what i'm talking about.

Thanks for your time!
Sincerely,
Elliott Martin

Comment 1 Mario Tanev 2003-02-18 19:16:44 UTC

I would like to confirm the same here

Comment 2 George Staikos 2003-04-07 06:06:20 UTC

Definitely a bug.

Comment 3 lypanov 2003-10-18 23:25:49 UTC

nothing for me...

Alex

Comment 4 Olivier Goffart 2003-10-19 10:13:09 UTC

Without looking at the code, but just because i saw this report on the core-devel mailinglist:

I guess you use some widget (toolbar buttons) plugged into the toolbar and you set the toolbar as parent for them. The toolbar will be deleted when editing toolbar. So buttons will be deleted too.

A solution could to give no parent to theses widget and delete it manualy when konqueror close,  or recreates button when configuring toolbar.

Comment 5 Tobias Koenig 2003-11-01 17:39:53 UTC

Subject: kdebase/konqueror

CVS commit by tokoe: 

Refill the bookmark toolbar whenever the toolbar is configured.
That fixes #50495.
CCMAIL:50495-done@bugs.kde.org


  M +5 -3      konq_mainwindow.cc   1.1252


--- kdebase/konqueror/konq_mainwindow.cc  #1.1251:1.1252
@@ -367,6 +367,6 @@ void KonqMainWindow::initBookmarkBar()
 
   if (!bar) return;
-  if (m_paBookmarkBar) return;
 
+  delete m_paBookmarkBar;
   m_paBookmarkBar = new KBookmarkBar( KonqBookmarkManager::self(), m_pBookmarksOwner, bar, m_bookmarkBarActionCollection, this );
   connect( m_paBookmarkBar,
@@ -1701,6 +1700,9 @@ void KonqMainWindow::slotConfigureToolba
   KEditToolbar dlg(factory());
   connect(&dlg,SIGNAL(newToolbarConfig()),this,SLOT(slotNewToolbarConfig()));
-  if ( dlg.exec() )
+  connect(&dlg,SIGNAL(newToolbarConfig()),this,SLOT(initBookmarkBar()));
+  if ( dlg.exec() ) {
     createGUI( m_pViewManager->activePart() );
+    initBookmarkBar();
+  }
 }

Comment 6 lypanov 2003-11-03 18:21:16 UTC

*** Bug 66667 has been marked as a duplicate of this bug. ***

Comment 7 Maksim Orlovich 2003-11-17 19:29:36 UTC

*** Bug 68440 has been marked as a duplicate of this bug. ***