Summary: | Dynamic Tab Resizing in Konqueror | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Ivan Kozik <ivan> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | allergy, czarnowski, dominik.stadler, juanjux, michaelperik |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Simple patch to reduce tab-title-length based on number of tabs |
Description
Ivan Kozik
2002-09-28 04:34:15 UTC
*** Bug 48850 has been marked as a duplicate of this bug. *** Currently the width of tabs always depends on the title, maximal 30 letters are shown before the title is cut (I'm using ArkLinux alpha 7 which includes KDE pre-3.1.1). I'd prefer to at least be able to set my own amount of allowed letters in tabs if a dynamical resize is not possible in near future. *** Bug 56841 has been marked as a duplicate of this bug. *** I completely agree. This is one feature my mother desperately wants. She gets confused about where she is logged in. I have produce a very rough patch that at least eases this bug somewhat for me. It just reduces the number of characters put into the patch from 30 down to 2 based on the number of tabs. It does no real calculation of the available space, I just assume that normally 90 characters fit into the tab-title-bar, so it will still exceed the available size if you have a small window and will cut off tab-titles earlier if your screen is big. I think the real solution for this bug needs to change the implementation of QTabWidget in the qt-library where all necessary information about the width of the tab-titles is available... Created attachment 1668 [details]
Simple patch to reduce tab-title-length based on number of tabs
It's not a bug and your patch doesn't look good: It doesn't add "...", assumes a specific width (I have a wide-screen display, why shouldn't I allowed to use all of its width? :), doesn't restore the original length if more space is again available. Not talking about an unnecessary line and an unnecessary conditional. And please send your patches against HEAD. I think a real solution is possible without changing QTab*. Implemented in HEAD for KDE 3.2. I hope, as it satands this patch isn't satisfactory, but tis a good start. It should have resizing like Mozilla's 1.4 RC 1 though. I didn't commit this patch but my own implementation which behaves exactly like Mozilla's as far I can see. |